Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use lua_pop in synchro produces #2407

Closed
mercury233 opened this issue Dec 12, 2021 · 0 comments · Fixed by Fluorohydride/ygopro-core#606
Closed

don't use lua_pop in synchro produces #2407

mercury233 opened this issue Dec 12, 2021 · 0 comments · Fixed by Fluorohydride/ygopro-core#606
Labels

Comments

@mercury233
Copy link
Collaborator

Now we are using lua_pop(pduel->lua->current_state, 3); in synchro related produces.
This way we use lua stack is messy and dangerous, and it may cause problem.

There is a known problem that in android with lua 5.4, EFFECT_SYNCHRO_MATERIAL_CUSTOM will crash on the lua_pop step because lua seem trys to close to-be-closed variables which not exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants