Skip to content

Commit 96462d6

Browse files
Chris YangEgor
authored andcommitted
[video_player] Fix setWithOthers test (flutter#2970)
1 parent 078360f commit 96462d6

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

packages/video_player/video_player/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.10.12+2
2+
3+
* Fix `setMixWithOthers` test.
4+
15
## 0.10.12+1
26

37
* Depend on the version of `video_player_platform_interface` that contains the new `VideoPlayerOptions` class.

packages/video_player/video_player/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ description: Flutter plugin for displaying inline video with other Flutter
44
# 0.10.y+z is compatible with 1.0.0, if you land a breaking change bump
55
# the version to 2.0.0.
66
# See more details: https://github.com/flutter/flutter/wiki/Package-migration-to-1.0.0
7-
version: 0.10.12+1
7+
version: 0.10.12+2
88
homepage: https://github.com/flutter/plugins/tree/master/packages/video_player/video_player
99

1010
flutter:

packages/video_player/video_player/test/video_player_test.dart

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -579,11 +579,11 @@ void main() {
579579
expect(colors.backgroundColor, backgroundColor);
580580
});
581581

582-
test('setMixWithOthers', () {
582+
test('setMixWithOthers', () async {
583583
final VideoPlayerController controller = VideoPlayerController.file(
584584
File(''),
585585
videoPlayerOptions: VideoPlayerOptions(mixWithOthers: true));
586-
controller.initialize();
586+
await controller.initialize();
587587
expect(controller.videoPlayerOptions.mixWithOthers, true);
588588
});
589589
}
@@ -656,6 +656,11 @@ class FakeVideoPlayerPlatform extends VideoPlayerApiTest {
656656
void setVolume(VolumeMessage arg) {
657657
calls.add('setVolume');
658658
}
659+
660+
@override
661+
void setMixWithOthers(MixWithOthersMessage arg) {
662+
calls.add('setMixWithOthers');
663+
}
659664
}
660665

661666
class FakeVideoEventStream {

0 commit comments

Comments
 (0)