Skip to content

Commit fa43d46

Browse files
Michael KlimushynEgor
authored andcommitted
[none] Pass --custom-analysis flag through CI (flutter#2356)
This passes our currently failing plugins through to flutter_plugin_tools to adjust to flutter/plugin_tools#75.
1 parent b979db4 commit fa43d46

File tree

1 file changed

+19
-1
lines changed

1 file changed

+19
-1
lines changed

script/incremental_build.sh

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,28 @@ readonly REPO_DIR="$(dirname "$SCRIPT_DIR")"
66

77
source "$SCRIPT_DIR/common.sh"
88

9+
# Plugins that deliberately use their own analysis_options.yaml.
10+
#
11+
# This list should only be deleted from, never added to. This only exists
12+
# because we adopted stricter analysis rules recently and needed to exclude
13+
# already failing packages to start linting the repo as a whole.
14+
#
15+
# TODO(mklim): Remove everything from this list. https://github.com/flutter/flutter/issues/45440
16+
CUSTOM_ANALYSIS_PLUGINS=(
17+
"in_app_purchase"
18+
"camera"
19+
"google_sign_in/google_sign_in"
20+
"google_sign_in/google_sign_in_platform_interface"
21+
"google_sign_in/google_sign_in_web"
22+
)
23+
# Comma-separated string of the list above
24+
readonly CUSTOM_FLAG=$(IFS=, ; echo "${CUSTOM_ANALYSIS_PLUGINS[*]}")
925
# Set some default actions if run without arguments.
1026
ACTIONS=("$@")
1127
if [[ "${#ACTIONS[@]}" == 0 ]]; then
12-
ACTIONS=("test" "analyze" "java-test")
28+
ACTIONS=("analyze" "--custom-analysis" "$CUSTOM_FLAG" "test" "java-test")
29+
elif [ "${ACTIONS[@]}" == "analyze" ]; then
30+
ACTIONS=("analyze" "--custom-analysis" "$CUSTOM_FLAG")
1331
fi
1432

1533
BRANCH_NAME="${BRANCH_NAME:-"$(git rev-parse --abbrev-ref HEAD)"}"

0 commit comments

Comments
 (0)