Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong rrule dispatch for Array constructor #2033

Closed
chengchingwen opened this issue Aug 6, 2022 · 0 comments · Fixed by #2034
Closed

Wrong rrule dispatch for Array constructor #2033

chengchingwen opened this issue Aug 6, 2022 · 0 comments · Fixed by #2034

Comments

@chengchingwen
Copy link
Member

This would dispatch on all call to parametric type because typeof(Array) is UnionAll.

function ChainRulesCore.rrule(::typeof(Array), x::CUDA.CuArray)

It should be ::Core.Typeof(Array) or ::Type{Array}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant