Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using LogExpFunctions #331

Closed
cossio opened this issue Jul 7, 2021 · 2 comments
Closed

Consider using LogExpFunctions #331

cossio opened this issue Jul 7, 2021 · 2 comments

Comments

@cossio
Copy link

cossio commented Jul 7, 2021 •
edited
Loading

Consider using and re-exporting logsumexp from https://github.com/JuliaStats/LogExpFunctions.jl/blob/master/src/logsumexp.jl, instead of implementing it here (

NNlib.jl/src/softmax.jl

Line 140 in a3875e1

function logsumexp(x::AbstractArray; dims = :)
).

Notice that the LogExpFunctions implementation is more sophisticated (maybe faster?) and works for arbitrary iterators (via a one-pass algorithm).
@mcabbott
Copy link
Member

mcabbott commented Jul 8, 2021

Xref #252

@cossio cossio mentioned this issue Jul 9, 2021
Open
@CarloLucibello
Copy link
Member

closing in favor of #252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@CarloLucibello @cossio @mcabbott