Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable announcement does nothing #277

Closed
Luticus opened this issue Feb 9, 2016 · 3 comments
Closed

Disable announcement does nothing #277

Luticus opened this issue Feb 9, 2016 · 3 comments
Labels
Milestone

Comments

@Luticus
Copy link

Luticus commented Feb 9, 2016

App does not respect the "disable announcements" check box in the admin panel. If I check this box then leave the admin panel and go back to it later the box well be reset to an unchecked state. Announcements about the ownnote play store app are shown regardless of my wishes.

@mikebabb
Copy link

Possibly related to #287? ownNote settings in general not being saved?

@Fmstrat
Copy link
Owner

Fmstrat commented May 10, 2016

Fixed in 1f0a017

@Fmstrat Fmstrat closed this as completed May 10, 2016
@Fmstrat Fmstrat added this to the Server - 1.08 milestone May 10, 2016
@Fmstrat Fmstrat added the bug label May 10, 2016
@ejouvin
Copy link

ejouvin commented Jun 2, 2016

Fix in 1f0a017 does not fix the case for disableAnnouncement.
A pull request #312 is done for that, there was an error in the parameter name in AJAX call.

Moreover, I had an issue after upgrade to OwnCloud 9.0.X ?
In the table oc_appconfig, the config value for the key "disableAnnouncement" was NULL.
In this case, I was not able to update the setting.

I had to change with a blank string in the database, and there everything works fine.
update oc_appconfig set configvalue='' where configkey='disableAnnouncement' and appid='ownnote';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants