Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't strip "%" symbol from CSS selector #173

Closed
steveluscher opened this issue Jan 23, 2014 · 4 comments
Closed

Don't strip "%" symbol from CSS selector #173

steveluscher opened this issue Jan 23, 2014 · 4 comments
Milestone

Comments

@steveluscher
Copy link

I would like fontcustom to produce some SCSS with extend-only selectors (%). Unfortunately, my percent sign is converted to a hyphen on this line.

Would you be open to changing that?

@kaizau kaizau added this to the 1.3.3 milestone Feb 8, 2014
@kaizau
Copy link
Member

kaizau commented Feb 8, 2014

Good call. Added to the roadmap.

@fauxparse
Copy link

👍

Likewise HTML5 data attributes. I'd like to use them like this:

[data-icon="birdo"]:before { content: "\f100"; }

@binary-solo
Copy link

👍

I think you should be able to produce even invalid SCSS if you want. The mentioned .gsub() takes away the possibility of producing chained selectors as well (e.g. &.foo)

@endtwist
Copy link
Member

Fixed in 1.3.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants