Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to remove Ortography filter by clicking active filter #332

Closed
keunes opened this issue Aug 16, 2023 · 3 comments
Closed

Allow to remove Ortography filter by clicking active filter #332

keunes opened this issue Aug 16, 2023 · 3 comments

Comments

@keunes
Copy link

keunes commented Aug 16, 2023

Is your feature request related to a problem? Please describe.
The Ortography filter is mutually exclusive, i.e. one filter can be selected at the time. Clicking another item switches the filter, clicking the currently active filter doesn't do anything. The 'Clear selected filter' is displayed at the bottom, and not very visible. So it took me a while to remove a currently active filter.

Describe the solution you'd like
When clicking on an active filter, disable that filter.

Describe alternatives you've considered
Move the 'clear selected filter' button to the top, as that's where these type of 'clear filter' buttons often are. But this might throw off existing users and makes the button a bit too prominent.

Additional context
n/a

@JerryCasiano
Copy link
Contributor

I like this suggestion. Not sure if there's a technical reason why we don't this but I'll keep this in mind for the next version.

Thanks!

@JerryCasiano
Copy link
Contributor

So trying to enable I remembered that the current situation is a work around to the fact that GtkListView does not send "duplicate" selections.

I'll leave this open for now, there's probably some way to make this happen. But it is low on the priority list.

@JerryCasiano
Copy link
Contributor

You'll have to double click the selected row to deselect it now.

Couldn't get it working on a single click.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants