fix(connect): fix connect with enable_public for public facing (#17)

Author: hsinhoyeh

cmd/multikf/cmd_connect.go

@@ -19,7 +19,8 @@ func NewConnectCommand(logger log.Logger, ioStreams genericclioptions.IOStreams)
 
 func newConnectKubeflowCommand(logger log.Logger, ioStreams genericclioptions.IOStreams) *cobra.Command {
 	var (
-		port int // dedicated port
+		port         int  // dedicated port
+		enablePublic bool // enable public access
 	)
 	handle := func(machineName string) error {
 		m, err := findMachineByName(machineName, logger)
@@ -35,7 +36,11 @@ func newConnectKubeflowCommand(logger log.Logger, ioStreams genericclioptions.IO
 			}
 		}
 		logger.V(0).Infof("now you can open http://localhost:%d\n", destPort)
-		return m.GetKubeCli().Portforward(m.GetKubeConfig(), "svc/istio-ingressgateway", "istio-system", 80, destPort)
+		var listenedAddress string
+		if enablePublic {
+			listenedAddress = "0.0.0.0"
+		}
+		return m.GetKubeCli().Portforward(m.GetKubeConfig(), "svc/istio-ingressgateway", "istio-system", listenedAddress, 80, destPort)
 	}
 	cmd := &cobra.Command{
 		Use:   "kubeflow",
@@ -46,5 +51,6 @@ func newConnectKubeflowCommand(logger log.Logger, ioStreams genericclioptions.IO
 	}
 
 	cmd.Flags().IntVar(&port, "port", 0, "customized port number for connect, ranged should be 65535> >1024, default is 0 (random)")
+	cmd.Flags().BoolVar(&enablePublic, "enable_public", false, "enable public access, default: false")
 	return cmd
 }

pkg/machine/kubectl/cli.go

@@ -232,7 +232,7 @@ func (cli *CLI) PatchKubeflow(kubeConfigFile string) error {
 	return nil
 }
 
-func (cli *CLI) Portforward(kubeConfigFile, svc, namespace string, fromPort, toPort int) error {
+func (cli *CLI) Portforward(kubeConfigFile, svc, namespace string, address string, fromPort, toPort int) error {
 	// TODO: auto reconnect
 	cmdAndArgs := []string{
 		cli.localKubectlBinaryPath,
@@ -244,6 +244,12 @@ func (cli *CLI) Portforward(kubeConfigFile, svc, namespace string, fromPort, toP
 		"--kubeconfig",
 		kubeConfigFile,
 	}
+	if len(address) != 0 {
+		cmdAndArgs = append(cmdAndArgs, []string{
+			"--address",
+			address,
+		}...)
+	}
 	sr, _, err := cli.runCmd(cmdAndArgs)
 	if err != nil {
 		return err