Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mathematical functions #44

Merged
merged 8 commits into from
Feb 24, 2017
Merged

Mathematical functions #44

merged 8 commits into from
Feb 24, 2017

Conversation

gsomix
Copy link
Collaborator

@gsomix gsomix commented Feb 23, 2017 •
edited by ForNeVeR
Loading

@gsomix
Copy link
Collaborator Author

gsomix commented Feb 24, 2017

Properly parsed groups.

groups

@ForNeVeR ForNeVeR self-requested a review February 24, 2017 08:00
ForNeVeR
ForNeVeR reviewed Feb 24, 2017
View reviewed changes
src/WpfMath/TexFormulaParser.cs Outdated
@@ -550,12 +552,23 @@ private Atom AttachScripts(TexFormula formula, string value, ref int position, A
return atom;

// Check whether to return Big Operator or Scripts.
var subscriptAtom = subscriptFormula == null ? null : subscriptFormula.RootAtom;
var superscriptAtom = superscriptFormula == null ? null : superscriptFormula.RootAtom;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good place to use C# 6 syntax: subscriptFormula?.RootAtom, superscriptFormula?.RootAtom.

@gsomix gsomix changed the title [WIP] Mathematical functions Mathematical functions Feb 24, 2017
@ForNeVeR
Copy link
Owner

ForNeVeR commented Feb 24, 2017 •
edited
Loading

Regarding the localized function names: at the moment, I propose to add those common extensions and mark them with comment at the PredefinedTexFormulas.xml:

(except for the last two, of course: they aren't functions)

image

(Taken from a Russian LaTeX book «LATEX2ε в примерах» by К. В. Воронцов, p. 7.)

@ForNeVeR ForNeVeR mentioned this pull request Feb 24, 2017
Open
@ForNeVeR ForNeVeR merged commit d9a32f6 into master Feb 24, 2017
@ForNeVeR ForNeVeR deleted the feature/functions branch February 24, 2017 12:47
@ForNeVeR
Copy link
Owner

Thanks for contribution! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForNeVeR ForNeVeR ForNeVeR approved these changes

Assignees

@gsomix gsomix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsomix @ForNeVeR