You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Splitting up the bundles does not work with modules that are shimmed with browserify-shim.
I have a repo illustrating this at https://github.com/gabegorelick/browserify-shim-multiple. Note that everything works fine when done with browserify directly. It also works fine if only non-shimmed modules are included in the external bundle, e.g. if we only exclude jquery (the one from npm). It's only when you try to exclude shimmed modules, e.g. angular, and include them in a separate bundle that things break. And of course, everything works fine as a single bundle.
Looks like the issue only pops up when d3 (or anything that depends on it) is in the external module. Keeping d3 and everything that depends on it in the main module makes everything work. So it's something about browserify-middleware + browserify-shim + d3. I haven't been able to reproduce the issue with any other modules besides d3.
Splitting up the bundles does not work with modules that are shimmed with browserify-shim.
I have a repo illustrating this at https://github.com/gabegorelick/browserify-shim-multiple. Note that everything works fine when done with browserify directly. It also works fine if only non-shimmed modules are included in the external bundle, e.g. if we only exclude jquery (the one from npm). It's only when you try to exclude shimmed modules, e.g. angular, and include them in a separate bundle that things break. And of course, everything works fine as a single bundle.
See thlorenz/browserify-shim#40 for more context.
The text was updated successfully, but these errors were encountered: