Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple bundles don't work with browserify-shim #43

Closed
gabegorelick opened this issue Apr 18, 2014 · 2 comments
Closed

Multiple bundles don't work with browserify-shim #43

gabegorelick opened this issue Apr 18, 2014 · 2 comments

Comments

@gabegorelick
Copy link
Collaborator

Splitting up the bundles does not work with modules that are shimmed with browserify-shim.

I have a repo illustrating this at https://github.com/gabegorelick/browserify-shim-multiple. Note that everything works fine when done with browserify directly. It also works fine if only non-shimmed modules are included in the external bundle, e.g. if we only exclude jquery (the one from npm). It's only when you try to exclude shimmed modules, e.g. angular, and include them in a separate bundle that things break. And of course, everything works fine as a single bundle.

See thlorenz/browserify-shim#40 for more context.

@gabegorelick
Copy link
Collaborator Author

Looks like the issue only pops up when d3 (or anything that depends on it) is in the external module. Keeping d3 and everything that depends on it in the main module makes everything work. So it's something about browserify-middleware + browserify-shim + d3. I haven't been able to reproduce the issue with any other modules besides d3.

@ForbesLindesay
Copy link
Owner

If this only occurs with D3 I'm going to consider it as a wont-fix here. If you can come up with a small reproducible test case then I'll reconsider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants