Skip to content
This repository has been archived by the owner on Jul 25, 2018. It is now read-only.

developing config api #11

Open
BerkeleyTrue opened this issue Mar 6, 2015 · 2 comments
Open

developing config api #11

BerkeleyTrue opened this issue Mar 6, 2015 · 2 comments

Comments

@BerkeleyTrue
Copy link

Hello All,

We are going to be making heavy use of react-code-mirror over at freecodecamp.com/https://github.com/FreeCodeCamp/freecodecamp and would love to help move this project.

One thing that is missing is setting config options, such as setSize, setOption and setting operations on events.

I am opening up this issue to see if we can get some dialog about possible api options. I will be hacking up some options for us at freecodecamp so we can start using them immediately.

One possible idea would be for a separate config prop that takes an object and with properties such as `{setSize: [] } and then loop over the properties and calling them over the editor object. This is a simplistic way of doing things and will need some work still.

Let me know what yall think

cc @QuincyLarson @terakilobyte

@ForbesLindesay
Copy link
Owner

I'm open to suggestions. If you get something working that you think adds value, open a pull request. If it turns out to have been a mistake, we can always change it in the future (with a major version bump).

@izolate
Copy link

izolate commented Feb 15, 2016

@BerkeleyTrue Good idea. How far along are you on this PR?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants