Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scenario / test fixture: Tink #87

Open
3 tasks
ryan-roemer opened this issue Oct 17, 2018 · 2 comments
Open
3 tasks

Scenario / test fixture: Tink #87

ryan-roemer opened this issue Oct 17, 2018 · 2 comments

Comments

@ryan-roemer
Copy link
Member

ryan-roemer commented Oct 17, 2018

https://github.com/npm/tink

Should work like existing multiple-roots scenario.

Tasks:

  • The abstract dependency graph is not going to be automatically inferrable because everything is or or less flat.
    • Figure out if this is an actual problem and if we should do anything about it (docs, logic, special report, etc.)
    • Investigate if there is metadata from which we could recreate the abstract dependency graph. (Probably could from yarn.lock or package-lock.json if nothing else).
@zkat
Copy link

zkat commented Nov 2, 2018

You shouldn't need to do anything particularly special once tink is ready for use. Because it simulates node_modules, there's basically no real need to special-case anything: Just throw what you currently have at it and the analysis will be fairly accurate, unless you're trying to calculate the on-disk cost of the source files. If you're trying to calculate bundle sizes, though, it's all identical, or it should be. I'd rather you not have to do any extra work here! I want it to Just Work™!

@ryan-roemer
Copy link
Member Author

Thanks for the comment and great to hear!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants