Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: multi DOCUMENT_PATH not inferred correctly. #89

Open
4 tasks
ryan-roemer opened this issue Oct 19, 2018 · 2 comments
Open
4 tasks

BUG: multi DOCUMENT_PATH not inferred correctly. #89

ryan-roemer opened this issue Oct 19, 2018 · 2 comments
Labels

Comments

@ryan-roemer
Copy link
Member

ryan-roemer commented Oct 19, 2018

If we produce up with a bundle like:

/***/ 61:
/*!*******************************************************************************!*\
  !*** multi /PATH/TO/my-app/node_modules/next/dist/pages/_document.js ***!
  \*******************************************************************************/
/*! no static exports found */
/*! all exports used */
/*! ModuleConcatenation bailout: Module is not an ECMAScript module */
/***/ (function(module, exports, __webpack_require__) {

module.exports = __webpack_require__(/*! /PATH/TO/my-app/node_modules/next/dist/pages/_document.js */62);


/***/ }),

/***/ 62:
/*!*************************************************************************!*\
  !*** /PATH/TO/my-app/node_modules/next/dist/pages/_document.js ***!
  \*************************************************************************/
/*! no static exports found */
/*! all exports used */
/*! ModuleConcatenation bailout: Module is not an ECMAScript module */
/***/ (function(module, exports, __webpack_require__) {

module.exports = __webpack_require__(/*! next/document */ 63)

We get the plugin report of:

## static/HASH/pages/_document.js
next (Found 1 resolved, 1 installed. Latest version 7.0.0.)
  7.0.0
    ~/next
      * Dependency graph
        my-app@0.0.1 -> next@^7.0.0
      * Duplicated files in static/HASH/pages/_document.js
        next/dist/pages/_document.js (S, 42)

The issue: This is because the different sources:

  • multi /PATH/TO/my-app/node_modules/next/dist/pages/_document.js
  • /PATH/TO/my-app/node_modules/next/dist/pages/_document.js

both resolve to a short name of next/dist/pages/_document.js

Task

  • Dig into what multi NAME really means.
  • See if there are other things like multi that may occur?
  • Deal with the naming issue. (Maybe preserve multi?)
  • Add regression tests.
@ryan-roemer
Copy link
Member Author

Note: this may have been fixed / affected by: https://github.com/FormidableLabs/inspectpack/pull/107/files#diff-541cbeb9ca8eec86e3e65baa21d78144R70

Reassess the current issues before jumping in to this ticket...

@ryan-roemer
Copy link
Member Author

It also needs to be re-assessed if fullPath #106 actually ships.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant