Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

Keypress in demo fires twice for Firefox #70

Open
joshball opened this issue Jul 23, 2018 · 0 comments
Open

Keypress in demo fires twice for Firefox #70

joshball opened this issue Jul 23, 2018 · 0 comments

Comments

@joshball
Copy link

https://github.com/FormidableLabs/react-game-kit/blob/master/demo/slides/index.js#L36-L37
Adds both keyup and keypress listeners.
In Chrome/Edge, the arrow keys only fire keyup.
But in Firefox, both events get fired and it results in a double key press.
I don't know if it a matter of just removing the keypress handler? Or keeping both and handling it with some logic on the browser type? I am not a front end guy, and googling hasn't led me to a definitive solution, so if you have thoughts, I am sure you all handle this kind of stuff all the time. I am happy to submit a PR if you suggest a solution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant