Skip to content
This repository has been archived by the owner on May 11, 2023. It is now read-only.

New repeat api issues #124

Closed
boygirl opened this issue Feb 25, 2021 · 3 comments · Fixed by #126
Closed

New repeat api issues #124

boygirl opened this issue Feb 25, 2021 · 3 comments · Fixed by #126

Comments

@boygirl
Copy link
Contributor

boygirl commented Feb 25, 2021

First of all, thank you for this new feature. It's super ergonomic and easy to use! I noticed a few minor issues (none of which will prevent me from using the feature right away) that I wanted to document.

when repeat is an even number

I would expect the animation to stop cleanly at the from position, but instead it appears to jump back to the to position after completing.
even-numbers

when repeat is undefined

repeat: 0 causes no animation, as expected, but repeat: undefined causes a single animation when the component loads. I would expect all falsey values to behave like repeat: 0

repeat-undefined

when repeat is a string

I didn't read the release notes carefully enough and initially tried repeat: "infinite" instead of repeat: Infinity 😅 This resulted in an animation that started and continued past its to state. It should probably not start at all when the repeat value is an incorrect type
spinny-hand

@boygirl
Copy link
Contributor Author

boygirl commented Feb 25, 2021

@parkerziegler on second thought, I think the repeat: undefined behavior is desirable as is

@parkerziegler
Copy link
Contributor

FYI @boygirl the fixes have been released in v0.9.1! Let me know if you have issues with upgrade — ready to help out however I can. The release notes call out the new behavior!

@boygirl
Copy link
Contributor Author

boygirl commented Mar 8, 2021

Thanks so much!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants