(graphcache) - Allow partial schema to be passed for altered root names #1379
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1378
Summary
I had some of these changes done in a forgotten branch but never proposed / opened this since we didn't have a corresponding RFC just yet, and I didn't have time to write it up.
Basically, we should allow the root names to be altered without enabling full schema awareness for exceptional cases where schema awareness is explicitly not wanted. This is rather rare with the advent of GraphQL Code Generator's built-in plugin to resolve this at build time / deploy time but it may be helpful still.
It's now possible to pass only the root names like so:
Set of changes
SchemaIntrospector.types
optional and don't add it for partial schema introspection resultsthis.schema
from being set onStore
whenSchemaIntrospector.types
is missingschemaPredicates.ts
and fix up a test for this use-caseschema