-
-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) - allow passing operationContext to useQuery #351
Conversation
If there are no objections, I'd just like to merge this as is for now 😅 Potentially this could obviously be nicer, but since for most users On this note though, we may want to add the same modification to
Edit: Actually let's merge this for now so that we don't increase the scope of this PR :) |
Hmm, weird issue in the |
…/urql into chore/addOperationContext
@kitten just updating docs atm and then I think it's ready to merge, is there a spot that should be safe to note about the context and memoization of it? |
@JoviDeCroock I suppose we should add an entire section about the context somewhere, where we're also talking about customising urql. So maybe in "Extending & Experimenting". I'm thinking that doc can be extended with "FAQ-style" guides. E.g.: "How to write custom exchanges", "How to extend the context", etc |
All right, added it thanks for the heads up. It's rather small now but we can iterate on this. |
@JoviDeCroock let's discuss this tomorrow! There's a lot of todos for the docs anyway, so we can put down some specific todos for what sections need to be written 🙌 |
Fixes: #346