Implement active teardowns and add useQuery features to useSubscription #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a small bug in Wonka's onEnd operator where the Close signal wasn't propagated upwards after triggering the onEnd callback. Hence only one onEnd operator at a time would work and any chain of sources with onEnd in them wouldn't propagate unsubscriptions upwards correctly. This potentially had some negative implications for our cancelled requests. Further testing needed!
handler changes shouldn't trigger a new subscription as it wouldn't make much sense. The events from a subscription have already passed, so it's too late to swap it out. Instead we can keep a constant ref.
JoviDeCroock
approved these changes
Aug 26, 2019
|
Turns out I just forgot to use |
|
Verified this to be working on CodeSandbox, but more testing needed. There's a prerelease on npm under the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #407
I think the idea of adding "active teardowns" is pretty valuable. It may be required in the future for someone to actively cancel ongoing queries from exchanges. This is already necessary to correctly implement ending subscriptions.
This hence also adds missing features to the
useSubscriptionhook, likeexecuteSubscriptionandargs.pause. It also ensures that thehandlerarg is a constant ref, since reexecuting subscriptions when it changes wouldn't make much sense.Wonka had a slight bug in
onEnd. The operator wasn't propagatingClosesignals correctly, so the use ofonEndwould prevent unsubscriptions from propagating upwards.