Fix synchronous suspense cases on client-side #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoviDeCroock
approved these changes
Jan 13, 2020
kitten
force-pushed
the
fix/suspense-override
branch
from
508155c to
8dfe201
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a combined set of quirks that needed to be fixed. This PR also simplified the
toSuspenseSourceimplementation as a shorter one is possible.Essentially
wonkahad a problem with forwarding values in aswitchMapoperator, when the value was sent immediately on subscription before the operator had time to start.The
react-wonkaimplementation on the other hand would send a teardown even after the component suspended, which isn't necessary.Lastly, all combined, a teardown operation would be sent at the wrong time and when React unsuspended the subtree it would create two new subscriptions which would cause the latest subscription to always miss the newest result.
See: kitten/react-wonka#10
See: 0no-co/wonka#69