(core) - Expose client.subscription shortcut method #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 8b0d96d We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@kitten I did not bother adding tests because |
kitten
reviewed
May 26, 2020
kitten
changed the title
Co-authored-by: Phil Plückthun <phil@kitten.sh>
Co-authored-by: Phil Plückthun <phil@kitten.sh>
Co-authored-by: Phil Plückthun <phil@kitten.sh>
kitten
approved these changes
May 26, 2020
|
@kitten Can you please publish this soon? I realized this is also problem with a web project when running a subscription from XState machine. I know I can workaround that easily, but I would rather have the |
|
@FredyC We’re currently batching up several changes for a larger release cycle. If you’d like to use this change right now you can use it from the cache review packages that CodeSandbox CI publishes to its CDN |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #837
Summary
Expose
client.subscriptionto be correctly recognized by the exchange.Set of changes
An only small addition to
@urql/coreAPI.