(core) - Shorten queries for hashing #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 9521137 We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wgolledge
reviewed
Jul 18, 2020
| @@ -7,7 +7,8 @@ interface Documents { | |||
| [key: number]: DocumentNode; | |||
| } | |||
|
|
|||
| const hashQuery = (q: string): number => hash(q.replace(/[\s,]+/g, ' ').trim()); | |||
| const hashQuery = (q: string): number => | |||
| hash(q.replace(/([\s,]|#[^\n\r]+)+/g, ' ').trim()); | |||
There was a problem hiding this comment.
Looks good. I wonder if we should confirm that hashes only ever occur after newline+whitespace (though I'm sure this should be okay)
There was a problem hiding this comment.
@wgolledge I've added a test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This shortens the querystring by removing whitespaces and comments when a request is created with an unparsed query.