Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert class components to function components #2778

Open
10 of 29 tasks
KenanYusuf opened this issue Feb 5, 2024 · 0 comments
Open
10 of 29 tasks

Convert class components to function components #2778

KenanYusuf opened this issue Feb 5, 2024 · 0 comments
Labels
Issue: Accepted The submitted issue has been confirmed by the Victory core team
Milestone
Replace class inh...

Comments

@KenanYusuf
Copy link
Contributor

KenanYusuf commented Feb 5, 2024 •
edited by carbonrobot
Loading

Motivation

Most of the Victory components are classes. We should look at converting these to function components to simplify things a little and improve developer experience.

Components to convert

Some of these components may need to be converted simultaneously, and in some cases, it may make more sense to use component composition over class inheritance.
@KenanYusuf KenanYusuf self-assigned this Feb 5, 2024
@carbonrobot carbonrobot added the Issue: Accepted The submitted issue has been confirmed by the Victory core team label Feb 22, 2024
@carbonrobot carbonrobot mentioned this issue Mar 21, 2024
Open
@carbonrobot carbonrobot mentioned this issue Apr 26, 2024
Open
@FormidableLabs FormidableLabs locked and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Issue: Accepted The submitted issue has been confirmed by the Victory core team
Projects
None yet
Milestone
Replace class inheritance with compon...
Development

No branches or pull requests
2 participants
@carbonrobot @KenanYusuf