Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2820 Polyline segment label indicator #2849

Closed
wants to merge 20 commits into from
Closed

2820 Polyline segment label indicator #2849

wants to merge 20 commits into from

Conversation

acharyakavita
Copy link
Contributor

@acharyakavita acharyakavita commented Apr 3, 2024 •
edited
Loading

Description

Fixes # (issue)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run all builds, tests, and linting and all checks pass
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0aacf51

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
victory ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 3:44pm

@acharyakavita acharyakavita linked an issue Apr 3, 2024 that may be closed by this pull request
Polyline Label Indicators on Pie Chart #2820
Open
2 tasks
@acharyakavita
Copy link
Contributor Author

I am not sure why Victory-Area and Bar are showing up in UI tests as there is no change to the files related to these.

@carbonrobot
Copy link
Contributor

Closing given how out of sync this is with the current codebase, and we can revisit in the future.

@carbonrobot carbonrobot closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbonrobot carbonrobot Awaiting requested review from carbonrobot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Polyline Label Indicators on Pie Chart
2 participants
@acharyakavita @carbonrobot