Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating version to 37.1.1 - viewBox issue #2895

Open
2 tasks done
vuksharu93 opened this issue Sep 9, 2024 · 7 comments
Open
2 tasks done

Updating version to 37.1.1 - viewBox issue #2895

vuksharu93 opened this issue Sep 9, 2024 · 7 comments
Labels
Issue: Accepted The submitted issue has been confirmed by the Victory core team Type: Bug 🐛 Oh no! A bug or unintentional behavior

Comments

@vuksharu93
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Code of Conduct

  • I agree to follow this project's Code of Conduct

Victory version

37.1.1

Code Sandbox link

No response

Bug report

After updating the version from 37.0.2 to 37.1.1 none of the charts are displayed and I'm getting the warning: 
Invalid `viewBox` prop:0 0 undefined undefined

Steps to reproduce

No response

Expected behavior

No response

Actual behavior

No response

Environment

- Device: iPhone SE / Samsung Galaxy A51
- OS: iOS version 17.5.1 / Android version 13
- Node: 18.17.0
- npm:
@vuksharu93 vuksharu93 added the Type: Bug 🐛 Oh no! A bug or unintentional behavior label Sep 9, 2024
@vuksharu93
Copy link
Author

image

@roqmarcelo
Copy link

I am facing the same issue. I thought of adding width and height to the container component props, but it did not work.

@carbonrobot carbonrobot added the Status: Needs More Info ✋ A question or report that needs more info to be addressable label Sep 16, 2024
@victory-ci
Copy link
Collaborator

Hi there! It looks like your issue requires a minimal reproducible example, but it is invalid or absent. Please prepare such an example and share it with us.

The best way to get attention to your issue is to provide a clean and easy way for a developer to reproduce the issue on their own machine. Please do not provide your entire project, or a project with more code than is necessary to reproduce the issue.

A side benefit of going through the process of narrowing down the minimal amount of code needed to reproduce the issue is that you may get lucky and discover that the bug is due to a mistake in your application code that you can quickly fix on your own.

Resources

Common concerns

"I didn't have time to create one"

That's understandable, it can take some time to prepare. We ask that you hold off on filing an issue until you are able to fully complete the required fields in the issue template.

"You can reproduce it by yourself by creating a project and following these steps"

This is useful knowledge, but it's still valuable to have the resulting project that is produced from running the steps, where you have verified you can reproduce the issue.

@adamhari
Copy link

adamhari commented Sep 17, 2024

Experiencing the same issue. It seems to be coming from the container and, in my case, removing the containerComponent prop fixes the warning and layout issues. Can confirm that downgrading victory deps to 37.0.2 also fixes it.

@adamhari
Copy link

Created a snack with the issue here

@vuksharu93
Copy link
Author

@adamhari
Thanks!
Yes, it works when you delete containerComponent (with VictoryVoronoiContainer), but I need that :D
So, I will use 37.0.2 for now

@carbonrobot
Copy link
Contributor

Thanks for the reproduction, will add it to the queue

@carbonrobot carbonrobot added Issue: Accepted The submitted issue has been confirmed by the Victory core team and removed Status: Needs More Info ✋ A question or report that needs more info to be addressable labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Accepted The submitted issue has been confirmed by the Victory core team Type: Bug 🐛 Oh no! A bug or unintentional behavior
Projects
None yet
Development

No branches or pull requests

5 participants