Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bars always visible while zooming #2905

Open
2 tasks done
crcarlo opened this issue Oct 1, 2024 · 4 comments · Fixed by #2970
Open
2 tasks done

Make bars always visible while zooming #2905

crcarlo opened this issue Oct 1, 2024 · 4 comments · Fixed by #2970
Assignees
Labels
Issue: Accepted The submitted issue has been confirmed by the Victory core team Type: Enhancement ✏️ An enhancement or feature proposal that will be addressed after the next release

Comments

@crcarlo
Copy link
Contributor

crcarlo commented Oct 1, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Code of Conduct

  • I agree to follow this project's Code of Conduct

Feature Request

If you add a zoom container to a bar chart, bars will disappear as soon as the bar datapoint is outside the new "zoomed" domain.

This makes the the bars appear and disappear as you zoom in and out or pan across the chart.

Can we have the bars rendered if their width is still inside the zoomed domain?
@crcarlo crcarlo added the Type: Enhancement ✏️ An enhancement or feature proposal that will be addressed after the next release label Oct 1, 2024
@carbonrobot
Copy link
Contributor

I created a codesandbox we can use to illustrate the issue. With the default dataset, it seems to work as described. Could you fork the sandbox and add data to reproduce the issue?

https://codesandbox.io/p/sandbox/victory-starter-forked-3zd9hc

@crcarlo
Copy link
Contributor Author

crcarlo commented Oct 1, 2024

@carbonrobot I think the sanbox is not public as I see a "Sandbox not found" error

@crcarlo
Copy link
Contributor Author

crcarlo commented Oct 1, 2024

Yes, it's right there! It's easier to see by zooming first and then panning. Once the center of the bar is out of the view the whole bar disappears

Screen.Recording.2024-10-01.at.18.56.16.mov

@carbonrobot
Copy link
Contributor

Thanks for the video, that describes the issue well. Looks like the clipping path is tied to the grid center point.

@carbonrobot carbonrobot added the Issue: Accepted The submitted issue has been confirmed by the Victory core team label Oct 1, 2024
@nstolpe nstolpe self-assigned this Nov 7, 2024
@nstolpe nstolpe mentioned this issue Nov 14, 2024
12 tasks
@nstolpe nstolpe linked a pull request Nov 18, 2024 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Accepted The submitted issue has been confirmed by the Victory core team Type: Enhancement ✏️ An enhancement or feature proposal that will be addressed after the next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants