Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Candlestick with empty theme bug #3039

Open
carbonrobot opened this issue Jan 15, 2025 · 0 comments · May be fixed by #3043
Open

Candlestick with empty theme bug #3039

carbonrobot opened this issue Jan 15, 2025 · 0 comments · May be fixed by #3043
Assignees
@haneetsingh
Labels
Issue: Accepted The submitted issue has been confirmed by the Victory core team Type: Bug 🐛 Oh no! A bug or unintentional behavior

Comments

@carbonrobot
Copy link
Contributor

A <VictoryCandlestick> component with an empty theme does not render labels correctly.

Reproduction:

<VictoryCandlestick labels theme={{}} />

Expected:

Image

Actual:

TypeError: Cannot read properties of undefined (reading 'padding')
@carbonrobot carbonrobot added Type: Bug 🐛 Oh no! A bug or unintentional behavior Issue: Accepted The submitted issue has been confirmed by the Victory core team labels Jan 15, 2025
@haneetsingh haneetsingh self-assigned this Jan 17, 2025
@haneetsingh haneetsingh linked a pull request Jan 21, 2025 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haneetsingh haneetsingh

Labels
Issue: Accepted The submitted issue has been confirmed by the Victory core team Type: Bug 🐛 Oh no! A bug or unintentional behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: handle empty labelStyle values FormidableLabs/victory
2 participants
@carbonrobot @haneetsingh