Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Victory Website Doc Links Do Not Work In New Tabs/Windows #879

Closed
foxmicha opened this issue Dec 20, 2017 · 2 comments
Closed

Victory Website Doc Links Do Not Work In New Tabs/Windows #879

foxmicha opened this issue Dec 20, 2017 · 2 comments

Comments

@foxmicha
Copy link

The Problem

Links throughout the documentation are not setup properly. At some point the docs were put within an "open-source/victory" folder but the links within these docs have not been updated to reflect that. For example:

https://formidable.com/open-source/victory/docs/victory-bar/

The first link is to the Victory Chart page but it links to this address:

https://formidable.com/docs/victory-chart

This returns a 404 on navigation, making navigating through the docs frustrating.

Reproduction

Attempt to click any link found within the docs pages. The sidebar appears to have been updated but the links within each doc is not.

I'm sorry to open this on Github, but I couldn't find a more suitable place to make this known.

@foxmicha
Copy link
Author

Correction: The links work within the same browser window or tab but do no work when attempting to open the links in a new tab.

@foxmicha foxmicha changed the title Victory Website Links Not Updated Victory Website Doc Links Do Not Work In New Tabs/Windows Dec 20, 2017
@boygirl
Copy link
Contributor

boygirl commented Dec 20, 2017

This issue was moved to FormidableLabs/victory-docs#482

@boygirl boygirl closed this as completed Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants