Skip to content
This repository has been archived by the owner on Feb 17, 2022. It is now read-only.

hot reloading not working #20

Open
aubsw opened this issue Nov 7, 2017 · 4 comments
Open

hot reloading not working #20

aubsw opened this issue Nov 7, 2017 · 4 comments

Comments

@aubsw
Copy link

aubsw commented Nov 7, 2017

Hi, I think I'm seeing the exact same issue as #6

It seems that the whack server isn't watching my local dependancies while the server is running. I do get my updated files if I kill and restart the server. Is this expected?

Would be totally sick if I didn't have to restart the server, though even the current behavior is still a significant step up from before :)

Node: 8.4
npm: 5.5.1
rsync: 2.6.9
whackage: 1.2.0
RN: 0.49.5
Mac OS X Sierra

Thanks!

@JustinKasad
Copy link

I had the same issue @aubreywahl

The problem was the dependency in my whackage.json file had a trailing slash.
Removing that slash fixed everything

@wouterds
Copy link

wouterds commented Mar 2, 2018

@JustinKasad You had a trailing slash where? Not working here as well.

Node: 9.5.0
NPM: 5.6.0
whackage: 1.3.0
macOS 10.13.9
{
  "include": "/**/*.js",
  "exclude": [
    "/node_modules/*",
    ".babelrc",
    ".git"
  ],
  "dependencies": {
    "delta-client-blocks": "../client-blocks"
  }
}

@treyp
Copy link

treyp commented Mar 20, 2018

Trailing slash was a problem for me too. bash's path completion when typing whack link ../some-dir/ adds a trailing slash by default which then gets added to the whackage.json file which then breaks hot reloading. Sounds like an easy fix. Wish I had some free time right now to PR it.

@wouterds
Copy link

Actually, it is kinda working if I can make the component re-render myself, eg by switching views.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants