Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Deprecation of global built-in functions for Dart Sass 3.0.0 #20521

Open
2 tasks done
ahosgood opened this issue Jan 7, 2025 · 1 comment
Open
2 tasks done

Bug: Deprecation of global built-in functions for Dart Sass 3.0.0 #20521

ahosgood opened this issue Jan 7, 2025 · 1 comment
Labels

Comments

@ahosgood
Copy link

ahosgood commented Jan 7, 2025

Bug description

When building the SCSS using sass (v1.79.5), I get some deprecation warnings for an upcoming version of Dart Sass.

Some are about @import but those are covered in #19167 and #20501.

Others are about global built-in functions:

Deprecation Warning: Global built-in functions are deprecated and will be removed in Dart Sass 3.0.0.
Use string.unquote instead.

More info and automated migrator: https://sass-lang.com/d/import

   ╷
32 │     #{$fa-icon-property}: unquote('"#{ $icon }"');
   │                           ^^^^^^^^^^^^^^^^^^^^^^^
   ╵

Reproducible test case

https://github.com/nationalarchives/tna-frontend

Screenshots

To reproduce on our repo:

npm i
npm run compile:sass

Example output can be found in https://github.com/nationalarchives/tna-frontend/actions/runs/12599661104/job/35117055940 under "Test build package"

Font Awesome version

v6.7.2

Serving

Self-hosted

Implementation

CSS

Browser and Operating System

NodeJS Jod (22.x)

Web bug report checklist

  • I have included a test case because my odds go way up that the team can fix this when I do
  • I have searched for existing issues and to the best of my knowledge this is not a duplicate
@ahosgood ahosgood added bug needs-triage This bug needs to be confirmed labels Jan 7, 2025
@tagliala
Copy link
Member

tagliala commented Jan 7, 2025

Great, this is a good chance to make the breaking changes for #17644

@tagliala tagliala removed the needs-triage This bug needs to be confirmed label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants