Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miminal set of icons with add/remove overlay #5883

Closed
7 tasks
tagliala opened this issue Mar 8, 2015 · 6 comments
Closed
7 tasks

Miminal set of icons with add/remove overlay #5883

tagliala opened this issue Mar 8, 2015 · 6 comments
Assignees

Comments

@tagliala
Copy link
Member

tagliala commented Mar 8, 2015

Splitting out from #1181, which is about stacking any icon

Please do not suggest css based solutions here

@tagliala tagliala added this to the 5.0.0 milestone Mar 8, 2015
@tagliala tagliala changed the title Icons that will benefit from add/remove overlays Miminal set of icons that will benefit from add/remove overlays Mar 8, 2015
@tagliala tagliala changed the title Miminal set of icons that will benefit from add/remove overlays Miminal set of icons with add/remove overlays Mar 8, 2015
@tagliala tagliala changed the title Miminal set of icons with add/remove overlays Miminal set of icons with add/remove overlay Mar 8, 2015
@alaindeurveilher
Copy link

Hi I have a question: do you intent to create new icons ? For instance folder-plus. Will it be one new icon fa-folder-plus ?

If I understand correctly, your conclusion is to create a new set of icons. It seems so that you would like to create the whole icons directly. Which is great, and I think necessary (like the recent fa-user-plus since v4.3.0).
But also, if so, then, it leaves us with few customization.

I was working since a couple of days on a prototype proposal to submit to your team. The idea is to create a set of smaller icons, referenced as badges, and used them with the stackings. So for instance, having a set of bottom badges, always put at the same position in the bottom right corner of a the svg canvas. That way, all the icons will be placed at the same place.

In order for you to understand, i published my prototype. Let me know what you think, and if we can go in that direction.
Here is the link on github: https://github.com/AlainD-/font-awesome-badge
Or directly to the demo page: http://alaind-.github.io/font-awesome-badge/

When I started the new set of icon badges, I had the customization matters in mind. For instance, if one would like to create a yellow folder plus this way: yellow folder with a green plus.
In fact we could imagine more combination such as: a yellow folder, with a green plus, inside a blue disk the whole surrounded by a red circle. It's ugly but anyway, it's just to demonstrate the variety of possibilities. Try this for instance in the simulator on my page:

<span class="fa-stack fa-badge-stack fa-2x">
    <i class="fa fa-folder fa-stack-1x text-warning"></i>
    <i class="fa-badge fa-badge-bottom-circle-surround fa-stack-1x text-danger"></i>
    <i class="fa-badge fa-badge-bottom-circle fa-stack-1x text-success"></i>
    <i class="fa-badge fa-badge-bottom-plus fa-stack-1x text-info"></i>
</span>

Maybe we should consider both directions in order to meet a majority of user's expectations?

@tagliala
Copy link
Member Author

tagliala commented Mar 8, 2015

Hi I have a question: do you intent to create new icons ? For instance folder-plus. Will it be one new icon fa-folder-plus ?

Yes

Maybe we should consider both directions in order to meet a majority of user's expectations?

And yes! As I said, I like that workaround. It comes with some drawbacks but does the job. We can keep discuss about it in #1181

@alaindeurveilher
Copy link

HI, Is it possible to add the fa-database-* ?

@tagliala
Copy link
Member Author

@AlainD- please open a new request and refer to this issue (and #1181)

@alaindeurveilher
Copy link

Done #6072. But I don't see any option to attach new labels and reference to other issues (maybe because of user restriction).

@tagliala
Copy link
Member Author

I'm going to close this because of the new SVG Framework

@tagliala tagliala removed this from the 5.0.0 milestone Dec 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants