-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fa Counter is way too small #165
Comments
There is a https://github.com/FortAwesome/angular-fontawesome/issues/85. But I will look if we can fix/improve this somehow. |
I've looked at it and counter does behave as designed. The counter is supposed to be 1/4 of the icon's font size, that's why it is small, when icon size is 1x. In practice it is hard to make counter work perfectly for various combinations of icons, fonts and font sizes, so keeping it simple sounds like a reasonable approach. Then consumers can apply bits of CSS to make counter look good for their particular use case. Having said that I've looked at your StackBlitz and tried to make counter look good: https://stackblitz.com/edit/angular-z8v4ux-gzuzmd. What do you think? I've added |
We can probably expose these 3 values as component inputs to make customisation more user friendly. Also looks like some fixes to icon positioning are required ( |
You can use custom a custom default // SCSS
:root {
fa-layers {
font-size: 1em;
fa-layers-counter {
font-size: 1.2em;
}
}
} |
Describe the problem
The counter is very small on icons. completely illegible.
This is at 100% with just default icon size.
this is at 300% with just default icon size.
What did you expect?
to be able to see the counter number on the icon
Reproducible test case
https://angular-z8v4ux-ckohrf.stackblitz.io
The text was updated successfully, but these errors were encountered: