Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning messages due simple-html-tokenizer version #75

Open
ldalves opened this issue Sep 26, 2018 · 3 comments
Open

Warning messages due simple-html-tokenizer version #75

ldalves opened this issue Sep 26, 2018 · 3 comments

Comments

@ldalves
Copy link

ldalves commented Sep 26, 2018

After I installed @fortawesome/ember-fontawesome, I started getting some warning messages when running ember s.

# ember s
WARNING:
WARNING: /myapp/node_modules/simple-html-tokenizer/commands:
WARNING:    Missing package directory

These warnings were fixed in tildeio/simple-html-tokenizer#61.

However it seems that ember-fontawesome still uses old version of simple-html-tokenizer.

# npm ls simple-html-tokenizer
myapp@0.0.0 /myapp
+-- @fortawesome/ember-fontawesome@0.1.7
| `-- ember-ast-helpers@0.3.5
|   +-- @glimmer/compiler@0.27.0
|   | `-- simple-html-tokenizer@0.3.0
|   `-- @glimmer/syntax@0.27.0
|     `-- simple-html-tokenizer@0.3.0  deduped
`-- ember-cli-template-lint@1.0.0-beta.2
  `-- ember-template-lint@1.0.0-beta.5
    `-- @glimmer/compiler@0.36.2
      `-- @glimmer/syntax@0.36.2
        `-- simple-html-tokenizer@0.5.6

Is there anything we could do in order to avoid those warnings?

@hoIIer
Copy link

hoIIer commented Oct 28, 2018

I just added this to get around it until ember-ast-helpers is updated in this:

  "resolutions": {
    "@fortawesome/ember-fontawesome/**/ember-ast-helpers": "^0.4.0"
  }

@robmadole
Copy link
Member

Attempted to upgrade in #81 but either I did something silly/dumb or there is a dependency issue.

If anyone wants to give this a look that would be helpful. I don't have time right now to run the issue to ground but I'll try next week.

@jrjohnson
Copy link
Collaborator

This is a known issue with ember-ast-helpers: cibernox/ember-ast-helpers#21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants