-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.2.1 defaultProps migration introduces breaking change #562
Comments
Didn't realize there is already a pull-request discussing this issue: #559 |
Thanks, I'll take a look at this. |
Just released 0.2.2. Please give this a try. |
This was referenced Jun 29, 2024
This was referenced Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Release 0.2.1 introduces bug where explicitly passing
undefined
as a className causes an errorReproducible test case
Codepen Demo
Expected behavior
This has potential to break existing code. Maybe revert and save for a major release?
This code works for version 0.2.0 but not on 0.2.1
<FontAwesomeIcon className={undefined} icon={faUser} />
The text was updated successfully, but these errors were encountered: