Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not support style as array #28

Closed
emusgrave opened this issue Sep 9, 2019 · 5 comments · Fixed by #46
Closed

Does not support style as array #28

emusgrave opened this issue Sep 9, 2019 · 5 comments · Fixed by #46

Comments

@emusgrave
Copy link

When wrapping a FontAwesomeIcon component with a library like Styled-Components, a style array is passed to the underlying component instead of an object. This causes a YellowBox warning and also the passed styles do not take effect.

I've experimented and fixed this by calling StyleSheet.flatten on the style within the FontAwesomeIcon component.

Is there any objection/limitation to making this modification in the library? If not, I'll be happy to submit a PR.
@vskavgaci
Copy link

same problem

@cgibsonmm
Copy link

Would love to be able to use arrays with this which would allow for react-native-tailwind to work.

@joaohd98
Copy link

+1

@puremana puremana mentioned this issue Feb 13, 2020
Merged
@robmadole
Copy link
Member

I'm going to work with @puremana to try and get his PR merged

@robmadole
Copy link
Member

0.2.3 released to support arrays (thanks @puremana)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allowing the prop style as type array as well as an object puremana/react-native-fontawesome
5 participants
@robmadole @vskavgaci @emusgrave @cgibsonmm @joaohd98