Incorrect relative path (project_url) in index.html

[d7919]

After merging the recent set of merged commits into my fork I noticed that my main index.html no longer renders correctly and have identified that this is because the project_url used for all relative links in this page have changed from being "." to "..". All other pages (that I've looked at) render fine, although I suspect this will also be an issue for the search page.

I suspect this is related to the delayed rendering introduced in 56c262a as around this line we force the use of "." in creating the IndexPage but then change to ".." for everything else. In the past this worked because the IndexPage html was generated at instance creation but now it's not generated until we write the actual file which means it sees the updated value ".." rather than the value at creation time ".".

A quick fix for this is to move the if block here to just before this line, with the change data --> self.index.data. Probably want to also move the if block here to just after here (with the same change) to ensure we leave the final state unchanged.

[d7919]

I have an example of the quick fix in my fork. I've not created a PR (yet) as there may be a better way to fix this.

[haraldkl]

I think, this solution did not quite work for me. I had to do c13fe7b to get the paths correct. Though, I am also not sure what the correct solution would be.

[cmacmackin]

Relative paths have always been a pain to get working correctly and I was never able to find an approach which I liked. I'll take a closer look at this and see if inspiration strikes.

…

On 05/04/17 15:58, haraldkl wrote: I think, this solution did not quite work for me. I had to do c13fe7b <cmacmackin@c13fe7b> to get the paths correct. Though, I am also not sure what the correct solution would be. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <https://github.com/cmacmackin/ford/issues/204#issuecomment-291888965>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHxJPbrnBxrNV8JBUVif1modtuS0ddrLks5rs6wzgaJpZM4M0Nab>.

-- Chris MacMackin cmacmackin.github.io <https://cmacmackin.github.io>

[d7919]

@haraldkl I actually went for your approach first as a test. Do you know which part of the other approach didn't work for you (e.g. did something break or did it just not fix the index issue)?

[haraldkl]

I think it just did not work in all places. Maybe the links in the graphs were broken?

[haraldkl]

OK the comments on this are in #191, and it looks like the commit c13fe7b is the one that broke the graphs, in addition I needed ab84c5d. Thus, maybe I am just wrongly remembering this and your approach actually works.

[cmacmackin]

I think this is now working? I haven't come across any problems since merging your commits, anyway.

[haraldkl]

I also believe it works as it is right now. We are using relative paths with this version of FORD, without noticing any issues.

[cmacmackin]

I'll close the issue then.

[haraldkl]

However, there is also df9f30d, so there might still be some dragons lurking in there.