Add option to edit structured addresses #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I accidentally commited changes in ViewContactActivity which is an independent topic. I will split that out into a different PR. |
stephanritscher
force-pushed
the
structured-addresses-pr
branch
from
84cecad to
24d08fb
Compare
|
btw use draft if you arent done :) or Are you done? :) |
|
I think I'm done 😁 |
|
I didn't close this one either |
|
I detached all the forked Fossify repositories and as a result, PRs originating from SMT forks are being closed automatically. Please consider the following solution:
Sorry for the inconvenience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this fork and depending on this PR for Commons, introduce option to edit structured addresses as requested in #30.
In the current state, the PR changes the dependency to my fork of Commons. This needs to be revisited before merging (but probably after merging the PR for Commons).