Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some thumbnails wont render #148

Closed
7 tasks done
Meteor0id opened this issue Feb 27, 2024 · 16 comments
Closed
7 tasks done

some thumbnails wont render #148

Meteor0id opened this issue Feb 27, 2024 · 16 comments
Labels
bug Something is not working

Comments

@Meteor0id
Copy link

Meteor0id commented Feb 27, 2024

Checklist

  • I can reproduce the bug with the latest version given here.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected app version

1.1.1

Affected Android/Custom ROM version

android 10

Affected device model

Motorola moto g7 plus (nearly stock android)

How did you install the app?

None

Steps to reproduce the bug

Hi, I noticed some previews aren't rendering for all types of media (videos, gifs, movie). Clearing cache made no difference. These media can still be viewed properly by tapping and opening single view mode.
I have attached one of the images for which the app fails to show a preview in folder view.

Hope this helps.

Expected behavior

Thumbnails render while scrolling the gallery

Actual behavior

Thumbnails never shows up

Screenshots/Screen recordings

Screenshot_20240227-162354

Here is the file itself

RDT_20240217_1337493113863773608935546

And zipped to preserve properties
RDT_20240217_1337493113863773608935546.zip

Additional information

No response

@Meteor0id Meteor0id added bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Feb 27, 2024
@Aga-C
Copy link
Member

Aga-C commented Feb 27, 2024

  1. Fill the template properly, especially fields about the device.
  2. 6.28.1 is not the latest version of the app.
  3. File link doesn't work.

@Aga-C Aga-C added waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. template missing The bug/feature template is missing labels Feb 27, 2024
@Meteor0id
Copy link
Author

@Aga-C updated
It was a copy paste text from the old repo where users got sold out. New file, yes the bug is still present in current public release

@github-actions github-actions bot removed the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Feb 27, 2024
@Aga-C
Copy link
Member

Aga-C commented Feb 27, 2024

Please fill Affected device model because it is relevant. I've just tested on two different devices (image downloaded from ZIP) and have no problem, thumbnail is generated and displayed correctly.

@Aga-C Aga-C added waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. device/software specific Issues that only happen on some devices or with some specific hardware/software labels Feb 27, 2024
@Meteor0id
Copy link
Author

@Aga-C updated, moto g7. Can't see an obvious reason why my device is affected anything I could check?

@github-actions github-actions bot removed the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Feb 27, 2024
@Aga-C Aga-C removed needs triage Issue is not yet ready for PR authors to take up template missing The bug/feature template is missing labels Feb 27, 2024
@Aga-C
Copy link
Member

Aga-C commented Feb 27, 2024

@naveensingh Do you have any idea what more information we may need?

@Meteor0id
Copy link
Author

Meteor0id commented Feb 27, 2024

Settings
Screenshot_20240227-165520

Color sceme looks like old app but was imported

Only the preview wont load, if I tap on it the full screen inage does show

@inson1
Copy link
Contributor

inson1 commented Feb 27, 2024

its jpg, not crazy big (10MB), resolution is little bit bigger, but still in the norm 2k/4k

@naveensingh
Copy link
Member

naveensingh commented Feb 28, 2024

@naveensingh Do you have any idea what more information we may need?

Maybe. @Meteor0id are you familiar with Android Studio or adb logcat? Can you get some logs for us? Glide often dumps useful info into the logs.

I have one Motorola phone with similar specs, I'll try to reproduce this. I think I might have seen this bug before on an emulator.

@Aga-C
Copy link
Member

Aga-C commented Mar 10, 2024

@Meteor0id Do thumbnails work correctly when you turn off Animate GIFs at thumbnails?

@Aga-C Aga-C added question Further information is requested waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. labels Mar 10, 2024
@naveensingh
Copy link
Member

Possibly related: https://www.reddit.com/r/Fossify/comments/1b43ifl/gallery_many_gif_thumbnails_missing/

I was gonna create a separate issue but this one might suffice.

@Meteor0id
Copy link
Author

@Aga-C yes turning that off kakes them appear. You are onto something

@github-actions github-actions bot removed the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Mar 10, 2024
@Aga-C Aga-C removed device/software specific Issues that only happen on some devices or with some specific hardware/software question Further information is requested labels Mar 10, 2024
@Aga-C
Copy link
Member

Aga-C commented Mar 10, 2024

It seems to be only related to this setting, not to the device as I previously thought. Also, thumbnails for AVIF files doesn't work with this option turned on.

In code, I see that problem is with the line options.dontAnimate() in Context.loadImageBase. For some reason, it breaks both AVIF files and this JPEG.

@naveensingh
Copy link
Member

I can also reproduce this now. Both with AVIF and the JPG provided above. I'll investigate this later today.

Thanks, Agni!

@Aga-C
Copy link
Member

Aga-C commented Mar 10, 2024

I've found out what's wrong with JPEG posted here. In fact, the file doesn't contain JPEG data but PNG data. For some reason, dontAnimate doesn't handle the case of wrong file extension.

@naveensingh
Copy link
Member

image
Hmmm.

@naveensingh
Copy link
Member

Should be fixed in https://github.com/FossifyOrg/Gallery/releases/tag/1.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
Development

No branches or pull requests

4 participants