Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Save without additional dialog #227

Open
7 tasks done
jtrees opened this issue May 14, 2024 · 4 comments
Open
7 tasks done

Feature Request: Save without additional dialog #227

jtrees opened this issue May 14, 2024 · 4 comments
Labels
enhancement New feature or request needs triage Issue is not yet ready for PR authors to take up

Comments

@jtrees
Copy link

jtrees commented May 14, 2024

Checklist

  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.
  • I optionally donated to support the Fossify mission.

Feature description

Saving changes to an image should be low-friction and seamless. There should be no additional save dialog. Changes to an image could simply be saved with a filename suffix, preserving the original.

Why do you want this feature?

I always find it quite jarring when I edit an image (e.g. rotate it) then tap "save" and the save dialog pops up. The stock gallery app on my phone provides a much more seamless experience.

Additional information

To keep things flexible, there could be additional options for configuration such as...

  1. Replacing the original file on save (Add an option to replace original after edit #62)
  2. Using a customizable pattern for the new file name
  3. Disabling the "seemless save" feature entirely and sticking with the old dialog flow

... but (except maybe point 3) those probably shouldn't be considered in-scope for the issue at hand and could be implemented separately at a later time.

@jtrees jtrees added feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels May 14, 2024
@Aga-C Aga-C added enhancement New feature or request and removed feature request Issue is about a new feature in the app labels May 14, 2024
@Aga-C
Copy link
Member

Aga-C commented May 14, 2024

I think without save dialog should only be rotation. Other operations are destructible and users should be notified about it by save dialog.

@jtrees
Copy link
Author

jtrees commented May 15, 2024

I think without save dialog should only be rotation. Other operations are destructible and users should be notified about it by save dialog.

Note that this feature request does not propose any "destructible" operations (like in #62). All changes are saved to a new file. The original is always preserved.

@GfEW
Copy link

GfEW commented Sep 30, 2024

@Aga-C

I think without save dialog should only be rotation. Other operations are destructible and users should be notified about it by save dialog.

I beg to differ on this one.

It's a rather common concept (if not default) that if you open a file, edit it and save it, you immediately overwrite the file with the edited version. By opening a file in an editor, you typically agree to this workflow. If you want to save your edits to a different file instead, you simply use the dedicated Save as ... button, shortcut or menu element.
If you prefer to safeguard the risk of inadvertent saving, you can also enable backup copies.

This discrepancy already makes Fossify Gallery's compulsory "Save as ..." dialog enough of a nuisance it should be optional. If the user prefers, tapping the checkmark icon should suffice to immediately save the changes to the current file, just like pressing the "Save" button (or Ctrl+S etc.) in most text/image/audio/younameit editors does.

Alas, the compulsory "Save as ..." dialog is even more tedious in practice, since it, once you've tapped OK to confirm the existing name, always runs into the obvious "name conflict" that requires yet another moot tap at Yes to confirm the overwrite.

Requiring three taps for every single save-in-place operation is beyond reasonable if you (like me) edit pictures in place, anyway.

(And in the rare case I really mean to save my edits to a new file, there are viable other options:

  • (a) open in external editor (that offers both, "Save" and "Save as ...")
  • (b) create a copy, then edit

Akin to (a), Fossify Gallery could also offer both "Save" and "Save as ...", either by separate button or by overloading the existing one:

  • tap to "Save"
  • long-tap to "Save as ...".)

@thisisartman
Copy link

100% agreed on everything above.

Akin to (a), Fossify Gallery could also offer both "Save" and "Save as ...", either by separate button or by overloading the existing one:

  • tap to "Save"
  • long-tap to "Save as ...".)

As for this, I'd like to suggest Google Photos' choices:

Screenshot_20241001-121513.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage Issue is not yet ready for PR authors to take up
Projects
None yet
Development

No branches or pull requests

4 participants