Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hope to add the option to set the cache upper limit #260

Open
6 of 7 tasks
LuoXiaoHel-Cat opened this issue Jul 12, 2024 · 3 comments
Open
6 of 7 tasks

Hope to add the option to set the cache upper limit #260

LuoXiaoHel-Cat opened this issue Jul 12, 2024 · 3 comments
Labels
enhancement New feature or request needs triage Issue is not yet ready for PR authors to take up

Comments

@LuoXiaoHel-Cat
Copy link

Checklist

  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.
  • I optionally donated to support the Fossify mission.

Feature description

add or remove the cache size limit .

Why do you want this feature?

cache limit 250MB is tooooooooo small . it take so much time to reload the thumbnails.

Additional information

No response

@LuoXiaoHel-Cat LuoXiaoHel-Cat added feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Jul 12, 2024
@Aga-C
Copy link
Member

Aga-C commented Jul 12, 2024

We can't make the cache larger than 250 MB (library limit: https://github.com/bumptech/glide/wiki/Configuration#disk-cache). Also, problem with slow loading of thumbnails is known and reported here: #136.

@Aga-C Aga-C closed this as not planned Won't fix, can't repro, duplicate, stale Jul 12, 2024
@Aga-C Aga-C added invalid This does not seem right and removed feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Jul 12, 2024
@Aga-C Aga-C mentioned this issue Oct 16, 2024
7 tasks
@pegelf
Copy link

pegelf commented Jan 6, 2025

For me, the documentation reads like the 250MB is a default value that can be changed:
https://github.com/bumptech/glide/blob/3.0/library/src/main/java/com/bumptech/glide/load/engine/cache/DiskCache.java#L18

According to the linked Wiki page:
You can set the size of the disk cache using the InternalCacheDiskCacheFactory.

@Aga-C Aga-C reopened this Jan 6, 2025
@Aga-C Aga-C added enhancement New feature or request needs triage Issue is not yet ready for PR authors to take up and removed invalid This does not seem right labels Jan 6, 2025
@LuoXiaoHel-Cat
Copy link
Author

so happy to hear that!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage Issue is not yet ready for PR authors to take up
Projects
None yet
Development

No branches or pull requests

3 participants