-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rotating Device Brings You Back To First File #51
Comments
I can't reproduce it. Can you provide more details?
BTW. Version in device info is a version of the app, not your exact OS version. |
I believe this person is having the same issue: SimpleMobileTools/Simple-Gallery#3051
Checked: Play videos auto, loop videos, allow controlling with gestures
Checked: Enable pull to refresh
Checked: Auto hide system ui, allow closing fullscreen view with down gesture, show notch if available,rotate media by system setting |
Just to be sure:
|
Both issues seem to be the same yes. When you are in the grid view, you single tap an image or video to view it full screen. Then swipe left or right, then turn the device. It rotates, then hops back to that first file no matter how many files you swiped through |
To be clear though, this issue was present before the fork. So it's nothing you have changed. |
Thanks for clarifying! I still can't reproduce the issue (I have a non-rooted OnePlus), so I suppose it's device or OS specific. Probably also related to #54. |
I have this issue as well on my OnePlus 12. @manigmaX (on SMT Git) pointed out that it happens with a high DPI. I normally run my phone at 520 (set in Developer Settings). The issue goes away if I keep the DPI under 478. |
I investigated this for a little bit and I think this is happening only when the activity is recreated. An indirect way to reproduce this is to toggle the system's dark theme or just fold/unfold if you have a foldable.
@replica9000 Is your OnePlus running Android 14? |
@seniorm0ment @replica9000 here's an APK with a potential fix: #160 (comment) Let me know if it works, thanks! |
@naveensingh The apk you provided fixes the issue for me, thank you! My OnePlus is running A14, but the issue was the same on my older OnePlus running A13 as well. |
@replica9000 I guess I'll accept my PR then :) |
Checklist
Describe the bug
When scrolling through videos, and then rotate the device, it resets back to the first clicked video.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Expect it to rotate screen and stay on current file
Device info (please complete the following information):
The text was updated successfully, but these errors were encountered: