Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotating Device Brings You Back To First File #51

Closed
seniorm0ment opened this issue Jan 4, 2024 · 11 comments · Fixed by #160
Closed

Rotating Device Brings You Back To First File #51

seniorm0ment opened this issue Jan 4, 2024 · 11 comments · Fixed by #160
Labels
bug Something is not working device/software specific Issues that only happen on some devices or with some specific hardware/software

Comments

@seniorm0ment
Copy link

Checklist

  • [X ] I can reproduce the bug with the latest version.
  • [ X] I made sure that there are no existing issues - open or closed - to which I could contribute my information to.
  • [X ] I have read the FAQ and my problem isn't listed.
  • [ X] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • [X ] This issue contains only one bug.
  • [ X] I have read and understood the contribution guidelines.

Describe the bug
When scrolling through videos, and then rotate the device, it resets back to the first clicked video.

To Reproduce
Steps to reproduce the behavior:

  1. Go to video, click it
  2. Start scrolling through videos and photos
  3. Rotate the device
  4. See it flicker then bring you back to the first file

Expected behavior
Expect it to rotate screen and stay on current file

Device info (please complete the following information):

  • Model: Pixel 8 Pro
  • OS: Android 14 GrapheneOS
  • Version: 2023123100
@seniorm0ment seniorm0ment added bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Jan 4, 2024
@Aga-C
Copy link
Member

Aga-C commented Jan 4, 2024

I can't reproduce it. Can you provide more details?

  • Can you tell what settings do you have in sections: Videos, Scrolling, Fullscreen media? If you can, screenshots would be the best.
  • In the first step, do you mean clicking on a video in a grid view with all videos, or you're already in the full-screen video and you're clicking it?
  • How are you rotating? Do you have auto-rotating in OS? Or do you have it blocked in OS, and you're only relying on rotating via app setting?

BTW. Version in device info is a version of the app, not your exact OS version.

@Aga-C Aga-C added question Further information is requested waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. labels Jan 4, 2024
@seniorm0ment
Copy link
Author

I believe this person is having the same issue: SimpleMobileTools/Simple-Gallery#3051
I went to go make the same issue there then realized the project was forked.

  • Version 1.1.0 from F-Droid
  • When in grid mode, you click a file, then start scrolling, rotate anytime. It also does it with Photos I just noticed too. Not strictly videos.

Videos

Checked: Play videos auto, loop videos, allow controlling with gestures

Scrolling

Checked: Enable pull to refresh

Fullscreen Media

Checked: Auto hide system ui, allow closing fullscreen view with down gesture, show notch if available,rotate media by system setting

@Aga-C
Copy link
Member

Aga-C commented Jan 4, 2024

Just to be sure:

  1. The issue you gave from SMT says about selecting images. By clicking image, you mean long pressing it to enter selection mode or just a single quick tap that brings you to full-screen display?
  2. Is it also the same as Screen Rotate issue/bug SimpleMobileTools/Simple-Gallery#2822?

@seniorm0ment
Copy link
Author

Just to be sure:

1. The issue you gave from SMT says about selecting images. By clicking image, you mean long pressing it to enter selection mode or just a single quick tap that brings you to full-screen display?

2. Is it also the same as [Screen Rotate issue/bug SimpleMobileTools/Simple-Gallery#2822](https://github.com/SimpleMobileTools/Simple-Gallery/issues/2822)?

Both issues seem to be the same yes.
And no, not when holding down.

When you are in the grid view, you single tap an image or video to view it full screen. Then swipe left or right, then turn the device. It rotates, then hops back to that first file no matter how many files you swiped through

@seniorm0ment
Copy link
Author

To be clear though, this issue was present before the fork. So it's nothing you have changed.
I do appreciate the efforts with the fork btw.

@Aga-C
Copy link
Member

Aga-C commented Jan 4, 2024

Thanks for clarifying! I still can't reproduce the issue (I have a non-rooted OnePlus), so I suppose it's device or OS specific. Probably also related to #54.

@Aga-C Aga-C added device/software specific Issues that only happen on some devices or with some specific hardware/software and removed question Further information is requested waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. needs triage Issue is not yet ready for PR authors to take up labels Jan 4, 2024
@replica9000
Copy link

I have this issue as well on my OnePlus 12. @manigmaX (on SMT Git) pointed out that it happens with a high DPI. I normally run my phone at 520 (set in Developer Settings). The issue goes away if I keep the DPI under 478.

@naveensingh
Copy link
Member

I investigated this for a little bit and I think this is happening only when the activity is recreated. An indirect way to reproduce this is to toggle the system's dark theme or just fold/unfold if you have a foldable.

adb shell cmd uimode night yes/no

@replica9000 Is your OnePlus running Android 14?

@naveensingh
Copy link
Member

@seniorm0ment @replica9000 here's an APK with a potential fix: #160 (comment)

Let me know if it works, thanks!

@replica9000
Copy link

@naveensingh The apk you provided fixes the issue for me, thank you!

My OnePlus is running A14, but the issue was the same on my older OnePlus running A13 as well.

@naveensingh
Copy link
Member

@replica9000 I guess I'll accept my PR then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working device/software specific Issues that only happen on some devices or with some specific hardware/software
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants