Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date cannot work #88

Closed
6 tasks done
llllllllqq opened this issue Jan 18, 2024 · 6 comments
Closed
6 tasks done

Fix date cannot work #88

llllllllqq opened this issue Jan 18, 2024 · 6 comments
Labels
invalid This does not seem right

Comments

@llllllllqq
Copy link

llllllllqq commented Jan 18, 2024

Checklist

  • I can reproduce the bug with the latest version.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Describe the bug
Fix date taken value function cannot work.

To Reproduce
Steps to reproduce the behavior:

  1. fresh reinstall.
  2. touch a photo to a wrong date than EXIF date.
  3. long press it and cick fix date taken value

Expected behavior
modified date should be the same as EXIF date.

Screenshots
If applicable, add screenshots to help explain your problem.

Device info (please complete the following information):

  • Model: [Xiaomi redmi K40]
  • OS: [Android 13]
  • App version [1.1.1]

Additional context
Add any other context about the problem here.

@llllllllqq llllllllqq added bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Jan 18, 2024
@Aga-C Aga-C removed the needs triage Issue is not yet ready for PR authors to take up label Jan 18, 2024
@Aga-C
Copy link
Member

Aga-C commented Jan 18, 2024

After using "Fix date taken" what exactly happens? Does it save any date as "Date taken" in EXIF? If it saves, then which date it saved?

@Aga-C Aga-C added question Further information is requested waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. needs triage Issue is not yet ready for PR authors to take up labels Jan 18, 2024
@llllllllqq
Copy link
Author

After using "Fix date taken"

nothing happened. The modified date of the photo and EXIF date keep untouched.

@Aga-C
Copy link
Member

Aga-C commented Jan 18, 2024

Does file's "Date created" is the same as EXIF "Date taken"?

@llllllllqq
Copy link
Author

llllllllqq commented Jan 18, 2024

Does file's "Date created" is the same as EXIF "Date taken"?

No.
Before and after "Fix date", the outputs below are identical.

$ stat IMG_20240114_120632.HEIC
  File: IMG_20240114_120632.HEIC
  Size: 1625687         Blocks: 3176       IO Block: 4096   regular file
Device: 0,179   Inode: 2242418     Links: 1
Access: (0660/-rw-rw----)  Uid: (    0/    root)   Gid: ( 9997/everybody)
Access: 2024-01-18 21:06:02.437792584 +0800
Modify: 2024-01-18 21:06:02.445792584 +0800
Change: 2024-01-18 21:06:02.445792584 +0800
 Birth: -

Screenshot_2024-01-18-22-00-16-688_org fossify gallery

I also tried JPG photo, same bug.

@Aga-C Aga-C removed question Further information is requested waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. labels Jan 18, 2024
@min7-i
Copy link

min7-i commented Jan 19, 2024

If I understand the "fix date taken" feature correctly, it won't update the last modified date to match the exif date taken. In case that is what you expected it to do.

Here's an explanation SimpleMobileTools/Simple-Gallery#2951 that should still be valid:
grafik

And here's a short video demonstrating the feature.

The photos are grouped by date taken (monthly), but as you can see the photo is assigned to "Unbekannt" (unknown) although it does have a date taken (exif data). After using the "fix date taken" feature it is correctly assigned to January 2024. Both the modified date and the date taken stay unchanged.

fix.date.taken_demo_edit.mp4

@Aga-C
Copy link
Member

Aga-C commented Jan 19, 2024

@min7-i Thanks for the explanation!

@Aga-C Aga-C closed this as completed Jan 19, 2024
@Aga-C Aga-C added invalid This does not seem right and removed bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Jan 19, 2024
@Aga-C Aga-C closed this as not planned Won't fix, can't repro, duplicate, stale Jan 26, 2024
@Aga-C Aga-C mentioned this issue Jan 1, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This does not seem right
Projects
None yet
Development

No branches or pull requests

3 participants