Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Initial support for sim colors #27

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

derrohrbach
Copy link

@derrohrbach derrohrbach commented Jan 17, 2024

Here is my initial draft for sim color support. Feel free to already comment on it. Things left to do:

  • Move sim color conversions to commons library, so we can use it in SMS app too
  • Test with more designs
  • Check/Work on CallActivity and ConferenceActivity
  • Maybe also rework SelectSIMDialog (most likely seperate PR)

This fixes/implements: SimpleMobileTools/Simple-Dialer#322

@naveensingh
Copy link
Member

@derrohrbach I'll check this soon...

If the PR isn't ready to merge yet, you can convert it to a draft PR to signal that.

@derrohrbach derrohrbach marked this pull request as draft January 22, 2024 21:04
@derrohrbach
Copy link
Author

@naveensingh Hey, thanks. I did not know that, since I'm used to the GitLab workflow where you just name your MR "WIP".

@derrohrbach
Copy link
Author

Only thing missing is moving the extension function to the common library. What is the workflow for that? Do I first submit a PR there and wait for a version to be built/published so i can update the reference in this project?

Or should I just copy this one function over to the SMS app?

@naveensingh
Copy link
Member

naveensingh commented Mar 17, 2024

@derrohrbach

What is the workflow for that? Do I first submit a PR there and wait for a version to be built/published so i can update the reference in this project?

Please raise a PR in Commons. Once the PR is merged, anyone can trigger a Jitpack build at this page: https://jitpack.io/#org.fossify/commons/

@naveensingh naveensingh added waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. and removed waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. labels Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants