Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show location of number in call history #39

Open
5 tasks done
Rexadev opened this issue Jan 19, 2024 · 6 comments
Open
5 tasks done

Show location of number in call history #39

Rexadev opened this issue Jan 19, 2024 · 6 comments
Labels
feature request Issue is about a new feature in the app

Comments

@Rexadev
Copy link

Rexadev commented Jan 19, 2024

Checklist

  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Is your feature request related to a problem? Please describe.
I would like to see the city, state, province, country of the numbers

Describe the solution you'd like

@Rexadev Rexadev added feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Jan 19, 2024
@Aga-C Aga-C removed the needs triage Issue is not yet ready for PR authors to take up label Jan 19, 2024
@Aga-C
Copy link
Member

Aga-C commented Jan 19, 2024

I found this library: https://github.com/google/libphonenumber/, but I'm not sure whether we can use this to have such detailed information.

@Rexadev
Copy link
Author

Rexadev commented Jan 19, 2024

Let us start with country
@Aga-C

@rsb-23
Copy link

rsb-23 commented Jan 26, 2024

We can display country name using country codes stored as dictionary / HashMap.

@naveensingh
Copy link
Member

Yes, anything beyond the country might be hard to do without increasing the app size. Last I checked libphonenumber's metadata was around 15-20MB and even then we won't have proper info for each number.

@vertigo220
Copy link

If app size is a concern, there could be a companion app or separate ones, one with and one without this and perhaps other advanced features, essentially a full and lite version. Whenever I get a call from an unknown number, I always have to look it up to see who it is or, at least, where it is, and it would be nice to have this kind of info displayed automatically.

@inson1
Copy link

inson1 commented Feb 7, 2024

Does somebody knows how many different locations that library actually has? so we could know if its worth it or not? we dont have to have 100% coverage to be adding this library worth it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is about a new feature in the app
Projects
None yet
Development

No branches or pull requests

6 participants