Skip to content

Commit 7c36764

Browse files
committed
Conflicts resolution fixes, pt 2
1 parent 4903c18 commit 7c36764

12 files changed

+26
-69
lines changed

phoenix-scala/phoenix/app/phoenix/models/cord/OrderPayment.scala

+3-5
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import core.db._
66
import core.failures.Failure
77
import core.utils.Money._
88
import core.utils.Validation._
9-
import failures.Failure
9+
import core.failures.Failure
1010
import phoenix.models.cord.OrderPayments.filter
1111
import phoenix.models.payment.PaymentMethod
1212
import phoenix.models.payment.PaymentMethod.ExternalPayment
@@ -16,10 +16,8 @@ import phoenix.models.payment.giftcard.{GiftCard, GiftCards}
1616
import phoenix.models.payment.storecredit.{StoreCredit, StoreCredits}
1717
import phoenix.utils.aliases.stripe.StripeCustomer
1818
import shapeless._
19-
import utils.Money._
20-
import utils.Validation._
21-
import utils.db.ExPostgresDriver.api._
22-
import utils.db._
19+
import core.db.ExPostgresDriver.api._
20+
import core.db._
2321

2422
case class OrderPayment(id: Int = 0,
2523
// FIXME @anna WTF is wrong with these defaults?

phoenix-scala/phoenix/app/phoenix/models/payment/ExternalCharge.scala

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
package phoenix.models.payment
22

33
import com.pellucid.sealerate
4-
import failures.Failures
4+
import core.failures.Failures
55
import phoenix.models.payment.ExternalCharge.State
66
import slick.ast.BaseTypedType
77
import slick.jdbc.JdbcType
8-
import utils.db.FoxModel
8+
import core.db._
99
import phoenix.utils.{ADT, FSM}
1010

1111
trait ExternalChargeVals {

phoenix-scala/phoenix/app/phoenix/models/payment/applepay/ApplePayCharge.scala

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ import phoenix.utils.aliases.stripe.StripeCharge
99
import shapeless.{Lens, lens}
1010
import slick.jdbc.PostgresProfile.api._
1111
import slick.lifted._
12-
import utils.Money.Currency
13-
import utils.db._
12+
import core.utils.Money.Currency
13+
import core.db._
1414

1515
case class ApplePayCharge(id: Int = 0,
1616
orderPaymentId: Int,

phoenix-scala/phoenix/app/phoenix/models/payment/applepay/ApplePayment.scala

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@ import java.time.Instant
44

55
import cats.implicits._
66
import cats.data.ValidatedNel
7-
import failures.Failure
7+
import core.db._
8+
import core.failures.Failure
9+
import core.utils.Validation
810
import phoenix.models.payment.PaymentMethod
911
import shapeless.{Lens, lens}
1012
import slick.jdbc.PostgresProfile.api._
11-
import utils.Validation
12-
import utils.db._
1313

1414
case class ApplePayment(
1515
id: Int = 0,

phoenix-scala/phoenix/app/phoenix/models/payment/creditcard/CreditCardCharge.scala

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package phoenix.models.payment.creditcard
22

33
import java.time.Instant
4-
import failures.Failures
4+
import core.failures.Failures
55
import com.pellucid.sealerate
66
import core.db._
77
import core.failures.Failures
@@ -12,11 +12,11 @@ import phoenix.models.payment.ExternalCharge._
1212
import phoenix.utils._
1313
import phoenix.utils.aliases.stripe._
1414
import shapeless._
15-
import utils.Money.Currency
15+
import core.utils.Money.Currency
1616
import slick.ast.BaseTypedType
1717
import slick.jdbc.JdbcType
1818
import slick.jdbc.PostgresProfile.api._
19-
import utils.db._
19+
import core.db._
2020

2121
case class CreditCardCharge(id: Int = 0,
2222
creditCardId: Int,

phoenix-scala/phoenix/app/phoenix/models/returns/ReturnCcPayment.scala

-41
This file was deleted.

phoenix-scala/phoenix/app/phoenix/models/returns/ReturnStripePayment.scala

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ import phoenix.models.payment.applepay.ApplePayCharges
44
import phoenix.models.payment.creditcard.CreditCardCharges
55
import shapeless._
66
import slick.jdbc.PostgresProfile.api._
7-
import utils.Money.Currency
8-
import utils.db._
7+
import core.db._
8+
import core.utils.Money.Currency
99

1010
case class ReturnStripePayment(id: Int = 0,
1111
returnPaymentId: Int,

phoenix-scala/phoenix/app/phoenix/services/Checkout.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package phoenix.services
33
import cats.implicits._
44
import com.github.tminglei.slickpg.LTree
55
import core.failures.GeneralFailure
6-
import failures.GeneralFailure
6+
import core.failures.GeneralFailure
77
import phoenix.failures.PromotionFailures.PromotionNotFoundForContext
88
import phoenix.failures.ShippingMethodFailures.NoDefaultShippingMethod
99
import objectframework.ObjectUtils

phoenix-scala/phoenix/app/phoenix/services/CordQueries.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import phoenix.models.payment.storecredit.StoreCreditAdjustments
1010
import phoenix.utils.aliases.EC
1111
import phoenix.models.payment.applepay.ApplePayCharges
1212
import slick.dbio.DBIO
13-
import utils.db._
13+
import core.db._
1414

1515
trait CordQueries {
1616

phoenix-scala/phoenix/app/phoenix/services/returns/ReturnPaymentManager.scala

+6-6
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ package phoenix.services.returns
22

33
import cats.implicits._
44
import core.db._
5-
import failures.GeneralFailure
5+
import core.failures.GeneralFailure
66
import phoenix.failures.OrderFailures.{OnlyOneExternalPaymentIsAllowed, OrderPaymentNotFoundFailure}
77
import phoenix.failures.ReturnFailures._
88
import phoenix.models.account.{Scope, User, Users}
@@ -21,7 +21,7 @@ import phoenix.utils.aliases._
2121
import phoenix.utils.apis.{Apis, RefundReason}
2222
import slick.jdbc.PostgresProfile.api._
2323
import scala.annotation.tailrec
24-
import utils.db._
24+
import core.db._
2525
import phoenix.models.payment.applepay.ApplePayments
2626

2727
object ReturnPaymentManager {
@@ -337,16 +337,16 @@ object ReturnPaymentManager {
337337
((id: String, amount: Int)
338338
for {
339339
_ * <~ apis.stripe.authorizeRefund(id, amount, RefundReason.RequestedByCustomer)
340-
ccPayment = ReturnCcPayment(
340+
ccPayment = ReturnStripePayment(
341341
returnPaymentId = payment.id,
342342
chargeId = id,
343343
returnId = payment.returnId,
344344
amount = amount,
345345
currency = payment.currency
346346
)
347-
created * <~ ReturnCcPayments.create(ccPayment)
347+
created * <~ ReturnStripePayments.create(ccPayment)
348348
} yield created).tupled
349-
.andThen(_.runTxn()) // we want to run each stripe refund in separate transaction to avoid any rollback of `ReturnCcPayments` table
349+
.andThen(_.runTxn()) // we want to run each stripe refund in separate transaction to avoid any rollback of `ReturnStripePayments` table
350350

351351
/** Splits total refund amount into order cc charges.
352352
*
@@ -377,7 +377,7 @@ object ReturnPaymentManager {
377377
for {
378378
previousCcRefunds * <~ Returns
379379
.findPreviousOrCurrent(rma)
380-
.join(ReturnCcPayments)
380+
.join(ReturnStripePayments)
381381
.on(_.id === _.returnId)
382382
.map { case (_, ccPayment) ccPayment.chargeId ccPayment.amount }
383383
.groupBy(_._1)

phoenix-scala/phoenix/app/phoenix/utils/apis/FoxStripeApi.scala

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ import phoenix.models.location.Address
77
import phoenix.models.payment.creditcard.CreditCard
88
import phoenix.payloads.PaymentPayloads.CreateCreditCardFromSourcePayload
99
import phoenix.utils.aliases.stripe._
10-
import utils.Money.Currency
11-
import utils.db._
10+
import core.utils.Money.Currency
11+
import core.db._
1212

1313
/**
1414
* Fox Stripe API wrapper

phoenix-scala/phoenix/test/integration/ApplePayIntegrationTest.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import cats.implicits._
2-
import failures.GeneralFailure
2+
import core.failures.GeneralFailure
33
import phoenix.failures.OrderFailures.OnlyOneExternalPaymentIsAllowed
44
import phoenix.models.location.Region
55
import phoenix.models.shipping._

0 commit comments

Comments
 (0)