Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework 13 AMD Support on Linux #20

Open
afzalarsalan opened this issue Nov 1, 2023 · 17 comments
Open

Framework 13 AMD Support on Linux #20

afzalarsalan opened this issue Nov 1, 2023 · 17 comments

Comments

@afzalarsalan
Copy link

I've noticed that trying this tool on Linux runs into the issue where /dev/cros_ec doesn't seem to exist on the latest kernel. I wanted to know if there was any blockers or action items that would enable this program's functionality to work on Linux

Failure Code

Self-Test
  SMBIOS Platform:     Framework13Amd
  SMBIOS is_framework: true
  Dump EC memory region
Failed to open /dev/cros_ec. Because: Os { code: 2, kind: NotFound, message: "No such file or directory" }
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', framework_lib/src/chromium_ec/cros_ec.rs:70:34
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
@JohnAZoidberg
Copy link
Member

You can use --driver portio to directly talk to the EC without a kernel driver. But it won't work with secureboot. See #16
But kernel driver fixes are already out there and coming soon.

@becausewat
Copy link

Is it intended that it's trying to talk to the CrOS EC when on an AMD board? I'm not 100% sure of the exact differences, but I'm pretty sure the EC on CrOS and non-CrOS devices serve some different functions.

@sserenade
Copy link

But kernel driver fixes are already out there and coming soon

Is there a mailing list thread or link one could use to track these fixes, to see what kernel version they might end up in?

@OctopusET
Copy link

@prurigro
Copy link

prurigro commented Nov 7, 2023

@OctopusET I just tested the patch and the kernel still doesn't provide /dev/cros_ec with it applied (thanks for taking a look though!)

@prurigro
Copy link

Seems like this is the patchset- I just applied it on 6.6.2 and framework_tool now functions correctly!

@dyslexicjedi
Copy link

You can use --driver portio to directly talk to the EC without a kernel driver. But it won't work with secureboot. See #16 But kernel driver fixes are already out there and coming soon.

This works for me. Thank you!

@AkechiShiro
Copy link

Hello @prurigro do you if the patchset you have shared has landed upstream yet in 6.7 ? I don't think it has but I haven't checked really thoroughly

@lengau
Copy link

lengau commented Feb 18, 2024

@AkechiShiro it's not in mainline 6.8-rc5, so it's probably not in 6.7.

@prurigro
Copy link

Yeah, I'm still patching it in to each 6.7.x release

@ufechner7
Copy link

Why not making portio the default?

@stefanhoelzl
Copy link

Why not making portio the default?

portio does not work when secure boot is enabled #16

@stefanhoelzl
Copy link

stefanhoelzl commented Apr 10, 2024

The patch series has been merged to the chrome platform tree for-next branch.

I guess it will then go into kernel 6.10

@Agno94
Copy link

Agno94 commented Apr 12, 2024

portio does not work when secure boot is enabled #16

You can temporarily lift kernel lockdown using https://github.com/blastrock/unlockdown while waiting for 6.10

@elreydetoda
Copy link

Seems like this is the patchset- I just applied it on 6.6.2 and framework_tool now functions correctly!

@prurigro , if you don't mind me asking, how are you doing this? I've never done that before, but I'd love to get this tool running w/o disabling Secure Boot or Kernel Lockdown. (till I get access to the 6.10 kernel)

@prurigro
Copy link

@elreydetoda Hey, so in Archlinux what I do is grab the package for the most recent kernel and add the patches to the build script before running it (ie: patch -Np1 < ../1.patch for each of the four patches). I'll drop them in an archive here so you don't have to dig them out of the mailing list.

Let me know if you need more detail in one direction or another- I didn't want to go too in depth considering how different an experience it would be depending on the distro you're using.

framework-system-amd-support.tar.gz

@prurigro
Copy link

I just tested the 6.10.2 release without any patches and framework_tool works with secure boot enabled. I believe this issue can be closed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests