Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies when using C-style code and the WPDS #309

Open
maximiliankaul opened this issue Oct 12, 2021 · 4 comments
Open

Inconsistencies when using C-style code and the WPDS #309

maximiliankaul opened this issue Oct 12, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@maximiliankaul
Copy link
Contributor

See https://github.com/Fraunhofer-AISEC/codyze/tree/mk/wpdscstyle for a test case. This branch just takes the Botan cpp testcases and mimics the behavior for an imaginary C - API. The results should not differ, but they do.

@maximiliankaul maximiliankaul added the bug Something isn't working label Oct 12, 2021
@maximiliankaul
Copy link
Contributor Author

There is a general problem with WPDS not correctly checking for an order rule to correct properly.
Neither the

.c test nor the .cpp test fail besides missing the required finish() call

Note: NFA works correctly.

@maximiliankaul
Copy link
Contributor Author

@oxisto I checked 06320a3 with the cpp code as discussed and it's broken, too :(

@maximiliankaul
Copy link
Contributor Author

@oxisto same with ba136fe

@maximiliankaul
Copy link
Contributor Author

Possible fix: TypestateAnalysis.kt:277 (oxisto)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant