Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2 #14

Closed
p0wdrdotcom opened this issue May 26, 2022 · 18 comments
Closed

ROS2 #14

p0wdrdotcom opened this issue May 26, 2022 · 18 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@p0wdrdotcom
Copy link

How do the maintainers feel about a port to ROS2?

I would be willing to participate.

@nznobody
Copy link

I would as well. I started, but it is quite the rabbit hole so I have shelved it for now.

https://github.com/nznobody/camera_aravis/tree/feature/ros2-bones

@kledom
Copy link
Contributor

kledom commented May 30, 2022

We have a ROS2 version of the package on our agenda, but not with the highest priority. I can't say for sure how long it will take, but hopefully in the near future (~2 months). However, we are always thankful for pull requests, if someone wants to tackle the issue already now.

@nznobody
Copy link

I would as well. I started, but it is quite the rabbit hole so I have shelved it for now.

https://github.com/nznobody/camera_aravis/tree/feature/ros2-bones

Nevermind, this was too much of a task for a quick achievement! A lot of refactoring :(

@kledom
Copy link
Contributor

kledom commented Oct 19, 2022

Since the package contains a lot of legacy code, the effort of porting to ROS2 should not be underestimated. Due to missing ROS2 features - namely the missing SubscriberStatusCallback - I have currently paused my efforts until the release of ROS 2 Iron Irwini.

@kledom kledom added enhancement New feature or request help wanted Extra attention is needed labels Oct 19, 2022
@patrikdaniel
Copy link

Since the package contains a lot of legacy code, the effort of porting to ROS2 should not be underestimated. Due to missing ROS2 features - namely the missing SubscriberStatusCallback - I have currently paused my efforts until the release of ROS 2 Iron Irwini.

ROS 2 Iron Irwini has been released in May. I'm curious if there are any updates or hints regarding the timeline for porting to ROS 2? It would be great to know when we can expect the transition. Thanks.

@boitumeloruf
Copy link
Collaborator

Hi... We are currently still quite busy with another project. Soon after that (in 1-2 months) we can again focus on camera_aravis. In the meantime, we welcome any help in porting it to ROS2.

@patrikdaniel
Copy link

Hi @boitumeloruf, I hope all is well. It's been two months since our last conversation regarding the camera_aravis project. I'm curious to know if there have been any updates or changes in its status. Thank you.

@boitumeloruf
Copy link
Collaborator

Hi @patrikdaniel, sorry for the late reply. Yes, there are updates. We plan to start/continue with porting camera_aravis to ROS2 next week or the week after. I know it is eagerly expected. We are also in need of it, as we are also starting to port our systems to ROS2 soon. Unfortunately, we were held up by other things.

@ruthvik92
Copy link

Hello,
I am using iDS GigE cameras in my ROS2 Humble based application. I am wondering if I can look forward to use your driver ?

@boitumeloruf
Copy link
Collaborator

Hi @ruthvik92, yes we have also deployed iDS GigE cameras on our systems. As soon as we have ported the driver to ROS2 you can use it.

@boitumeloruf
Copy link
Collaborator

Brief information on the topic of porting camera_aravis to ROS2:

We are currently in the middle of this process. In this, we are refactoring the code quite a bit. Thus, camera_aravis2 will not share the same code base as camera_aravis, which is why we have opted for a new, separate repository. As soon as we have a usable version of camera_aravis2, we will make the repository public and share the information here.

@patrikdaniel
Copy link

Hi @boitumeloruf, is there any update regarding the release date of camera_aravis2? Thanks a lot for your efforts.

@patrickwasp
Copy link

@patrikdaniel
It's not a comprehensive package, but while we wait for this one, maybe the demo I prepared could get you started.
https://github.com/patrickwasp/ros2_aravis_demo

@boitumeloruf
Copy link
Collaborator

Hi everyone,

we have a beta-version ready in a private repository. Unfortunately, our legal department has to approve the publication of it. Sorry for the delay. I will notify you, as soon as we have made the repository public.

@patrikdaniel
Copy link

@boitumeloruf, that's great news, thank you!

@patrikdaniel
Copy link

Hi @boitumeloruf,

Do you have any updates on the approval for publishing the repository?

Thank you!

@boitumeloruf
Copy link
Collaborator

Hi,

unfortunately not. We are still waiting for approval. Sorry!

@boitumeloruf
Copy link
Collaborator

Hello everyone,

I have some good news! We have now published the repository: https://github.com/FraunhoferIOSB/camera_aravis2
We will soon also release it as an official ROS package.

Please note, that not all features from camera_aravis have yet been implemented. Some features are still on the roadmap. Other features are marked as deprecated. Please have a look into the issue list for more information: https://github.com/FraunhoferIOSB/camera_aravis2/issues

With this, I will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

7 participants