Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some API entries are empty #23

Closed
SchmJo opened this issue Nov 4, 2022 · 6 comments
Closed

Some API entries are empty #23

SchmJo opened this issue Nov 4, 2022 · 6 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@SchmJo
Copy link
Collaborator

SchmJo commented Nov 4, 2022

These API entries are empty:

  • foxes.input.farm_layout
  • foxes.variables
  • foxes.constants

Maybe because these are variables/functions, not classes?

@SchmJo SchmJo added bug Something isn't working documentation Improvements or additions to documentation labels Nov 4, 2022
@SchmJo SchmJo self-assigned this Nov 4, 2022
@SchmJo SchmJo changed the title The API for "foxes.input.farm_layout" is empty Some API entries are empty Nov 4, 2022
@isdanni
Copy link

isdanni commented May 16, 2023

Following, most functions in the API - Foxes Documentation page are empty. Any plans to update this?

If adding specific introduction is too much a workload you may consider copying doc strings of each class such as class FarmController(FarmDataModel): ... to the API documentation. For each package(e.g. core), there should also include a few sentences on its high-level functionalities. For documentation at least input and return parameters should be included in the docs.

linking openjournals/joss-reviews#5464 for tracking review progress.

@SchmJo
Copy link
Collaborator Author

SchmJo commented May 30, 2023

Thanks for the remark (I was sick for two weeks, hence the late reply - sorry).

The documentation is generated by sphinx using autosummary with custom templates. This works fine for all classes (i.e., most of the foxes content), for example FarmController, but not for functions for some reason. It's a known issue which I still need to fix (any ideas, maybe?).

All classes docu is fine, reflecting the foxes sub-package structure in the API. Is my fixing this bug required for the publication? It's tedious..

Thanks again!

@isdanni
Copy link

isdanni commented May 31, 2023

Thanks for your update! Hope you have fully recovered.

A complete documentation(both class-level and function-level) are generally required for the publication. I'm not very familiar with using sphinx together with readthedocs but based on your description have you tried checking project module path(E.G. ./ or /../..) or raw logs for possible failed importing packages? Class modules imports working fine while function docstrings not showing up usually implies there might be some problem with customized templates.

If this is caused by sphinx package itself you may try raising an issue under the sphinx-doc repo.

Some references:

@SchmJo
Copy link
Collaborator Author

SchmJo commented Jun 1, 2023

Great, thanks for the links! I will try to fix this issue with these hints.

@SchmJo
Copy link
Collaborator Author

SchmJo commented Jun 2, 2023

Fixed in new version v0.3.5 (now main, merged into paper). Now the docu has a completely new look, and the API entries are complete.

@SchmJo
Copy link
Collaborator Author

SchmJo commented Jun 2, 2023

I will close this issue now, since the problem described here is solved. @isdanni feel free to re-open if you have doubts, thanks

@SchmJo SchmJo closed this as completed Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants