[Win32] Test Suite Failing on Windows CI

[FredKSchott]

Original Discussion: https://www.pika.dev/npm/snowpack/discuss/43
/cc @crra

@crra found an interesting bug on Windows, where --optimize (it looks like tree-shaking, specifically) throws an error due to a badly formatted import URL.

I do all my development on a mac, so we need to add Windows to our CI via GitHub Actions in some way. If anyone knows GitHub Actions well, I would love some help on this one.

(Okay to add the Windows CI tests even if they are failing, as long as it doesn't block merging PRs.)

[theashraf]

I'd like to help with this one

[FredKSchott]

@theashraf that would be great! I believe GH supports this out of the box. Let me know if you need contributor access to the repo to work on it.

[FredKSchott]

Update: We merged #156 into win-support branch, and are now seeing failing tests (due to bugs in code). Would love any help debugging these issues, and creating PRs with fixes against that branch!

Example: https://github.com/pikapkg/snowpack/runs/392311458

[yukukotani]

Failing tests seems to be a bug of npm cli. npm ci ignores os field so it trys to build fsevents on Windows.

Related issues: fsevents/fsevents#301, npm/cli#558

I'll keep watching this issue.

[FredKSchott]

I see this error in the CI logs:

jest-haste-map: Haste module naming collision: snowpack
  The following files share their name; please adjust your hasteImpl:
    * <rootDir>\package.json
    * <rootDir>\pkg\package.json

Maybe there's something there that we can track down? That doesn't seem fsevents related, but idk for sure

[yukukotani]

@FredKSchott
That warn occurred when running test after build. But it's not the cause of build failing.
In my local machine, it occurred but test succeed.

~/g/g/p/snowpack ❯❯❯ npm test                                                                                             win-support

> snowpack@1.0.5 test /Users/yukukotani/ghq/github.com/pikapkg/snowpack
> jest __tests__/runner.js

jest-haste-map: Haste module naming collision: snowpack
  The following files share their name; please adjust your hasteImpl:
    * <rootDir>/package.json
    * <rootDir>/pkg/package.json

 PASS  __tests__/runner.js (9.192s)
  ✓ dep-list-complex (1022ms)
  ✓ dep-list-simple (823ms)
  ✓ error-empty-dep-list (647ms)
  ✓ error-missing-dep (643ms)
  ✓ error-missing-nodemodules (645ms)
  ✓ error-no-dep-list (646ms)
  ✓ exclude (1282ms)
  ✓ include (1423ms)
  ✓ include-with-import-map (1428ms)

Test Suites: 1 passed, 1 total
Tests:       9 passed, 9 total
Snapshots:   0 total
Time:        9.926s
Ran all test suites matching /__tests__\/runner.js/i.

This warning would be fixed in #171.

[FredKSchott]

Oh interesting, that's so weird that it's failing but not giving us any output. I don't know what could be causing that (my comment in #171 may not be right, then)

[FredKSchott]

Fixed in #164